Closed Bug 1118424 Opened 5 years ago Closed 5 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in dom/html; r=baku

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8544787 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/html

Review of attachment 8544787 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLButtonElement.h
@@ +46,5 @@
>    NS_IMETHOD SaveState() MOZ_OVERRIDE;
>    bool RestoreState(nsPresState* aState) MOZ_OVERRIDE;
>    virtual bool IsDisabledForEvents(uint32_t aMessage) MOZ_OVERRIDE;
>  
>    virtual void FieldSetDisabledChanged(bool aNotify) MOZ_OVERRIDE; 

remove this extra space.

::: dom/html/nsHTMLDocument.h
@@ +84,1 @@
>   

extra spaces

::: dom/html/nsTextEditorState.cpp
@@ +214,5 @@
>      { return mFrameSelection; }
>  
>    //NSISELECTIONCONTROLLER INTERFACES
> +  NS_IMETHOD SetDisplaySelection(int16_t toggle) MOZ_OVERRIDE;
> +  NS_IMETHOD GetDisplaySelection(int16_t *_retval) MOZ_OVERRIDE;

* _retval here and all the others above.
Attachment #8544787 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/8c274aebb986
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.