Closed Bug 1118425 Opened 5 years ago Closed 5 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in dom/ipc; r=baku

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8544788 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/ipc

Review of attachment 8544788 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentBridgeChild.h
@@ +33,5 @@
>                                  const IPC::Principal& aPrincipal) MOZ_OVERRIDE;
>  
>    virtual PBlobChild*
>    SendPBlobConstructor(PBlobChild* actor,
> +                       const BlobConstructorParams& params) MOZ_OVERRIDE;

aParams

::: dom/ipc/ContentChild.cpp
@@ +808,5 @@
>  
>      NS_IMETHOD Callback(const nsACString &aProcess, const nsACString &aPath,
>                          int32_t aKind, int32_t aUnits, int64_t aAmount,
>                          const nsACString &aDescription,
> +                        nsISupports *aiWrappedReports) MOZ_OVERRIDE

type* var

::: dom/ipc/ContentParent.cpp
@@ +384,5 @@
>      virtual ~MemoryReportRequestParent();
>  
>      virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
>  
> +    virtual bool Recv__delete__(const uint32_t& generation, const InfallibleTArray<MemoryReport>& report) MOZ_OVERRIDE;

aGeneration, aReport

::: dom/ipc/ContentParent.h
@@ +502,5 @@
>      virtual bool RecvGetRandomValues(const uint32_t& length,
>                                       InfallibleTArray<uint8_t>* randomValues) MOZ_OVERRIDE;
>  
>      virtual bool RecvIsSecureURI(const uint32_t& type, const URIParams& uri,
> +                                 const uint32_t& flags, bool* isSecureURI) MOZ_OVERRIDE;

aValue

::: dom/ipc/TabParent.h
@@ +126,5 @@
>      void Destroy();
>  
>      virtual bool RecvMoveFocus(const bool& aForward) MOZ_OVERRIDE;
>      virtual bool RecvEvent(const RemoteDOMEvent& aEvent) MOZ_OVERRIDE;
> +    virtual bool RecvReplyKeyEvent(const WidgetKeyboardEvent& event) MOZ_OVERRIDE;

aEvent

@@ +127,5 @@
>  
>      virtual bool RecvMoveFocus(const bool& aForward) MOZ_OVERRIDE;
>      virtual bool RecvEvent(const RemoteDOMEvent& aEvent) MOZ_OVERRIDE;
> +    virtual bool RecvReplyKeyEvent(const WidgetKeyboardEvent& event) MOZ_OVERRIDE;
> +    virtual bool RecvDispatchAfterKeyboardEvent(const WidgetKeyboardEvent& event) MOZ_OVERRIDE;

same here
Attachment #8544788 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/d23b3009d77a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.