1118487 - Don't observe all "Gesture:DoubleTap" notifications just for reader mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[:Margaret Leibovic]

In bug 1111142 I punted on fixing this up, but it doesn't feel great that we're observing "Gesture:DoubleTap" globally to decide to scroll the about:reader page. It seems like it should be handled by the page itself.

Comment 1

[:Margaret Leibovic]

This came up in triage... do we even care about this double-tap-to-scroll feature? Most people in triage didn't even know we had that.

If this feature didn't exist, would we choose to implement it? If the answer is no, I would be in favor of removing it for the sake of code simplicity.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I can't say I have the context here but I don't think I've really ever used this feature myself. I'm OK with removing it for code simplicity but do we have any telemetry at all for this?

Comment 3

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #2)
> I can't say I have the context here but I don't think I've really ever used
> this feature myself. I'm OK with removing it for code simplicity but do we
> have any telemetry at all for this?

No, sorry, we don't have any telemetry for this feature. But I imagine it would be very small.

Comment 5

[:Margaret Leibovic]

antlam and I talked about this issue this morning and decided to just get rid of this. I'll write a patch.

Comment 6

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1118487/margaret

/r/4439 - Bug 1118487 - Remove double-tap-to-scroll behavior in reader view. r=bnicholson

Pull down this commit:

hg pull review -r 44e721aee6de3c4e4ca3d7bfa075a8ecf8241822

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 8570685 [details]
MozReview Request: bz://1118487/margaret

https://reviewboard.mozilla.org/r/4437/#review3691

Interesting. I didn't know about this either, though it sounds kind of useful as a quick "next page" feature. Should probably use something more discoverable though.

Comment 8

[Wesley Johnston (:wesj)]

I think this is a common feature in readers. But we really should just fire real doubleclick notifications when you doubletap. That's bug 820977.

Comment 9

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #8)
> I think this is a common feature in readers. But we really should just fire
> real doubleclick notifications when you doubletap. That's bug 820977.

Yeah, this should be implemented in about:reader the way a webpage would do it, not by listening for these double-tap messages from Java.

https://bugzilla.mozilla.org/show_bug.cgi?id=1118487

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/084827e66581

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Double tapping on the +/- button, does not perform a scroll on the page anymore; the action changes the text size, so:
Verified as fixed using:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 39.0a1 (2015-03-04)

Comment 12

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9923b668bf68

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Double tapping on the +/- button, does not perform a scroll on the page anymore; the action changes the text size, so:
Verified as fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 38.0a2 (2015-03-06)

Comment 15

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1118487 - Remove double-tap-to-scroll behavior in reader view. r=bnicholson