Closed Bug 1118487 Opened 5 years ago Closed 5 years ago

Don't observe all "Gesture:DoubleTap" notifications just for reader mode

Categories

(Firefox for Android :: Reader View, defect)

35 Branch
All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 39
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file, 1 obsolete file)

In bug 1111142 I punted on fixing this up, but it doesn't feel great that we're observing "Gesture:DoubleTap" globally to decide to scroll the about:reader page. It seems like it should be handled by the page itself.
This came up in triage... do we even care about this double-tap-to-scroll feature? Most people in triage didn't even know we had that.

If this feature didn't exist, would we choose to implement it? If the answer is no, I would be in favor of removing it for the sake of code simplicity.
Flags: needinfo?(deb)
Flags: needinfo?(alam)
I can't say I have the context here but I don't think I've really ever used this feature myself. I'm OK with removing it for code simplicity but do we have any telemetry at all for this?
Flags: needinfo?(alam) → needinfo?(margaret.leibovic)
(In reply to Anthony Lam (:antlam) from comment #2)
> I can't say I have the context here but I don't think I've really ever used
> this feature myself. I'm OK with removing it for code simplicity but do we
> have any telemetry at all for this?

No, sorry, we don't have any telemetry for this feature. But I imagine it would be very small.
Flags: needinfo?(margaret.leibovic)
Duplicate of this bug: 1137850
antlam and I talked about this issue this morning and decided to just get rid of this. I'll write a patch.
Assignee: nobody → margaret.leibovic
Flags: needinfo?(deb)
/r/4439 - Bug 1118487 - Remove double-tap-to-scroll behavior in reader view. r=bnicholson

Pull down this commit:

hg pull review -r 44e721aee6de3c4e4ca3d7bfa075a8ecf8241822
Attachment #8570685 - Flags: review?(bnicholson)
Comment on attachment 8570685 [details]
MozReview Request: bz://1118487/margaret

https://reviewboard.mozilla.org/r/4437/#review3691

Interesting. I didn't know about this either, though it sounds kind of useful as a quick "next page" feature. Should probably use something more discoverable though.
Attachment #8570685 - Flags: review?(bnicholson) → review+
I think this is a common feature in readers. But we really should just fire real doubleclick notifications when you doubletap. That's bug 820977.
(In reply to Wesley Johnston (:wesj) from comment #8)
> I think this is a common feature in readers. But we really should just fire
> real doubleclick notifications when you doubletap. That's bug 820977.

Yeah, this should be implemented in about:reader the way a webpage would do it, not by listening for these double-tap messages from Java.

https://bugzilla.mozilla.org/show_bug.cgi?id=1118487
https://hg.mozilla.org/mozilla-central/rev/084827e66581
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Double tapping on the +/- button, does not perform a scroll on the page anymore; the action changes the text size, so:
Verified as fixed using:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 39.0a1 (2015-03-04)
Status: RESOLVED → VERIFIED
Double tapping on the +/- button, does not perform a scroll on the page anymore; the action changes the text size, so:
Verified as fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 38.0a2 (2015-03-06)
Attachment #8570685 - Attachment is obsolete: true
Attachment #8619052 - Flags: review+
You need to log in before you can comment on or make changes to this bug.