Closed Bug 1118489 Opened 9 years ago Closed 9 years ago

promisifyCalendar mis-invokes Proxy constructor

Categories

(Calendar :: Internal Components, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: efaust, Assigned: efaust)

References

Details

Attachments

(1 file)

Attached patch calendarNewProxy.patch — — Splinter Review
After bug 945566 lands, this will throw. Just add a new keyword. If there are any others that I don't know about, they should also be patched.
Attachment #8544844 - Flags: review?(Pidgeot18)
Blocks: 945566
Comment on attachment 8544844 [details] [diff] [review]
calendarNewProxy.patch

Review of attachment 8544844 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks so much for keeping calendar in mind! I'm not aware of any other uses of Proxy in calendar/ code. r=philipp
Attachment #8544844 - Flags: review?(Pidgeot18) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4767a4d1c199 Turns out we found a place to sneak it in :)
Keywords: checkin-needed
Assignee: nobody → efaustbmo
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.9
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: