Last Comment Bug 1118489 - promisifyCalendar mis-invokes Proxy constructor
: promisifyCalendar mis-invokes Proxy constructor
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Internal Components (show other bugs)
: unspecified
: x86_64 Linux
-- normal (vote)
: 3.9
Assigned To: Eric Faust [:efaust]
:
:
Mentors:
Depends on:
Blocks: 945566
  Show dependency treegraph
 
Reported: 2015-01-06 14:22 PST by Eric Faust [:efaust]
Modified: 2015-01-07 08:25 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
calendarNewProxy.patch (1.01 KB, patch)
2015-01-06 14:22 PST, Eric Faust [:efaust]
philipp: review+
Details | Diff | Splinter Review

Description User image Eric Faust [:efaust] 2015-01-06 14:22:47 PST
Created attachment 8544844 [details] [diff] [review]
calendarNewProxy.patch

After bug 945566 lands, this will throw. Just add a new keyword. If there are any others that I don't know about, they should also be patched.
Comment 1 User image Philipp Kewisch [:Fallen] 2015-01-06 15:09:47 PST
Comment on attachment 8544844 [details] [diff] [review]
calendarNewProxy.patch

Review of attachment 8544844 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks so much for keeping calendar in mind! I'm not aware of any other uses of Proxy in calendar/ code. r=philipp
Comment 2 User image Eric Faust [:efaust] 2015-01-06 15:52:01 PST
https://hg.mozilla.org/comm-central/rev/4767a4d1c199 Turns out we found a place to sneak it in :)

Note You need to log in before you can comment on or make changes to this bug.