Closed Bug 1118497 Opened 5 years ago Closed 5 years ago

Rename "parameters" tab to "properties" in web audio editor

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

37 Branch
x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

"Parameters" implies that these are AudioParams, but lists both AudioParams, as well as unique properties to that node type (doesn't display channel and context information, but does display "type" on an oscillator, for example, which is not an AudioParam).

"Properties" would correctly identify both properties and AudioParams, which are stored as properties on the nodes.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attached patch 1118497-param-to-prop.patch (obsolete) — Splinter Review
Tiny patch
Attachment #8552093 - Flags: review?(vporof)
Comment on attachment 8552093 [details] [diff] [review]
1118497-param-to-prop.patch

Review of attachment 8552093 [details] [diff] [review]:
-----------------------------------------------------------------

Cute patch
Attachment #8552093 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/8486929aa855
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.