Closed
Bug 1118497
Opened 9 years ago
Closed 9 years ago
Rename "parameters" tab to "properties" in web audio editor
Categories
(DevTools Graveyard :: Web Audio Editor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.60 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
"Parameters" implies that these are AudioParams, but lists both AudioParams, as well as unique properties to that node type (doesn't display channel and context information, but does display "type" on an oscillator, for example, which is not an AudioParam). "Properties" would correctly identify both properties and AudioParams, which are stored as properties on the nodes.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8552093 [details] [diff] [review] 1118497-param-to-prop.patch Review of attachment 8552093 [details] [diff] [review]: ----------------------------------------------------------------- Cute patch
Attachment #8552093 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
rebased https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e35ffa5dc5e
Attachment #8552093 -
Attachment is obsolete: true
Attachment #8552574 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8486929aa855
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8486929aa855
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•