Closed
Bug 1118509
Opened 9 years ago
Closed 9 years ago
Enable test_settings_cell_data.py
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
Attachments
(1 file)
This test is enabled even though test_settings_dsds_cell_data.py is enabled and that is basically the same test. That doesn't make sense to me.
Assignee | ||
Comment 1•9 years ago
|
||
Like this? I don't really see the need for test_settings_dsds_cell_data.py, btw. It's the same test as test_settings_cell_data.py, but it's supposedly for 2 sims. Do we really need a specific test for that?
Attachment #8544864 -
Flags: review?(jlorenzo)
Comment 2•9 years ago
|
||
I agree, these are exactly the same test. Having one or 2 SIMs doesn't change anything in the UI today. It wasn't the case before though[1]. Viorela, do you think it's worth it to merge these 2 tests today? [1] https://github.com/mozilla-b2g/gaia/commit/1c520bd8d5c325c24fa6227b4f896cdc393789ee
Flags: needinfo?(viorela.ioia)
Comment 4•9 years ago
|
||
Comment on attachment 8544864 [details] [review] settings_cell_data Looks great with this removal and the explanation you provided. I would add another assertion before we merge this PR. Not sure of it though.
Attachment #8544864 -
Flags: review?(jlorenzo) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4) > Looks great with this removal and the explanation you provided. I would add > another assertion before we merge this PR. Not sure of it though. I answered this in the PR, that another assertion would basically be doing the same as the previous assertion.
Assignee | ||
Updated•9 years ago
|
Attachment #8544864 -
Flags: review?(florin.strugariu)
Updated•9 years ago
|
Attachment #8544864 -
Flags: review?(florin.strugariu) → review+
Comment 6•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/70ddce89af0a1dea6434890e950043d3c75ba94c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•