Closed
Bug 1118546
Opened 8 years ago
Closed 8 years ago
Mark virtual overridden functions as MOZ_OVERRIDE in dom/events; r=baku
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
9.30 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8544907 -
Flags: review?(amarchesini)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8544907 [details] [diff] [review] Mark virtual overridden functions as MOZ_OVERRIDE in dom/events Review of attachment 8544907 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/events/Event.h @@ +292,5 @@ > NS_FORWARD_NSIDOMEVENT(Event::) > > #define NS_FORWARD_NSIDOMEVENT_NO_SERIALIZATION_NO_DUPLICATION(_to) \ > + NS_IMETHOD GetType(nsAString& aType) MOZ_OVERRIDE { return _to GetType(aType); } \ > + NS_IMETHOD GetTarget(nsIDOMEventTarget * *aTarget) MOZ_OVERRIDE { return _to GetTarget(aTarget); } \ ** can you fix the & and * in this list of methods?
Attachment #8544907 -
Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/5d801822e67f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
||
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•