Mark virtual overridden functions as MOZ_OVERRIDE in dom/xul; r=baku

RESOLVED FIXED in mozilla37

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1117034
(Assignee)

Comment 1

3 years ago
Created attachment 8544909 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/xul
Attachment #8544909 - Flags: review?(amarchesini)
Comment on attachment 8544909 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/xul

Review of attachment 8544909 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xul/templates/nsXULContentBuilder.cpp
@@ +90,5 @@
>      NS_NewXULContentBuilder(nsISupports* aOuter, REFNSIID aIID, void** aResult);
>  
>      nsXULContentBuilder();
>  
> +    void Traverse(nsCycleCollectionTraversalCallback &cb) const MOZ_OVERRIDE

..Callback& aCb

::: dom/xul/templates/nsXULTreeBuilder.cpp
@@ +188,5 @@
>      virtual nsresult
>      ReplaceMatch(nsIXULTemplateResult* aOldResult,
>                   nsTemplateMatch* aNewMatch,
>                   nsTemplateRule* aNewMatchRule,
> +                 void *aContext) MOZ_OVERRIDE;

void* aContext
Attachment #8544909 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/2dc5720003ee
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.