Mark virtual overridden functions as MOZ_OVERRIDE in dom/xml; r=baku

RESOLVED FIXED in mozilla37

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1117034
(Assignee)

Comment 1

3 years ago
Created attachment 8544910 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/xml
Attachment #8544910 - Flags: review?(amarchesini)
Comment on attachment 8544910 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/xml

Review of attachment 8544910 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xml/nsXMLFragmentContentSink.cpp
@@ +53,2 @@
>    NS_IMETHOD HandleProcessingInstruction(const char16_t *aTarget, 
> +                                         const char16_t *aData) MOZ_OVERRIDE;

1. Can you remove these extra spaces?
2. nsAstring&, char16_t*

@@ +58,1 @@
>    NS_IMETHOD ReportError(const char16_t* aErrorText, 

extra space

@@ +58,4 @@
>    NS_IMETHOD ReportError(const char16_t* aErrorText, 
>                           const char16_t* aSourceText,
>                           nsIScriptError *aError,
> +                         bool *_retval) MOZ_OVERRIDE;

type* aVar

@@ +63,5 @@
>    // nsIContentSink
> +  NS_IMETHOD WillBuildModel(nsDTDMode aDTDMode) MOZ_OVERRIDE;
> +  NS_IMETHOD DidBuildModel(bool aTerminated) MOZ_OVERRIDE;
> +  NS_IMETHOD SetDocumentCharset(nsACString& aCharset) MOZ_OVERRIDE;
> +  virtual nsISupports *GetTarget() MOZ_OVERRIDE;

nsISupports* ..

@@ +79,5 @@
>  
>  protected:
>    virtual ~nsXMLFragmentContentSink();
>  
>    virtual bool SetDocElement(int32_t aNameSpaceID, 

extra space and type* aVar
Attachment #8544910 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/f8eb397de371
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.