If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use "enum class" directly instead of MOZILLA_PKIX_ENUM_CLASS

RESOLVED FIXED in mozilla37

Status

()

Core
Security: PSM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

Trunk
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8544988 [details] [diff] [review]
remove-MOZILLA_PKIX_ENUM_CLASS.patch

It seems like the GCC compiler bug that I worked around in bug 1077887 is no long relevant. This patch undoes that workaround.

It also renames some things that were named not-so-well do to the need to support non-scoped enums (without "enum class", multiple enums defined in the same scope cannot have the same labels like "No" and "Yes").
Attachment #8544988 - Flags: review?(mmc)
Comment on attachment 8544988 [details] [diff] [review]
remove-MOZILLA_PKIX_ENUM_CLASS.patch

Review of attachment 8544988 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning that up.
Attachment #8544988 - Flags: review?(mmc) → review+
Created attachment 8545642 [details] [diff] [review]
remove-MOZILLA_PKIX_ENUM_CLASS.patch
Attachment #8544988 - Attachment is obsolete: true
Attachment #8545642 - Flags: review+
Attachment #8545642 - Flags: checkin?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d65b051c1085
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/2880e05d5e32
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2880e05d5e32
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Attachment #8545642 - Flags: checkin?
You need to log in before you can comment on or make changes to this bug.