Closed Bug 11186 Opened 21 years ago Closed 21 years ago

[PP] Need better handling of regions in nsWindow::ScrollBits()

Categories

(Core :: XUL, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: pierre, Assigned: mikepinkerton)

Details

Note to QA: This bug report is just a reminder for a problem and a suggestion in
nsWindow::ScrollBits(). There is nothing you can do to reproduce/verify the fix.

Problem: the regions returned by NewRgn() must be checked for null.

Suggestion: you can re-use the nsNativeRegionPool from gfx/src/mac/
nsRegionMac.cpp or (why not?) allocate the 4 regions you need as static
variables.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
done. used the region pool stuff from gfx so we're not allocating/destroying
regions all the time. also created a stack-based helper so that we are guaranteed
of cleanup when we can't get a region for some reason.
verifying. code-level bug.
You need to log in before you can comment on or make changes to this bug.