Closed Bug 1118637 Opened 10 years ago Closed 10 years ago

Intermittent browser_site_loading_background_test.js | Browser - Site loading background validate loading background color

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: apastor)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

[gaia] albertopq:1118637-intermitent-browser-loading > mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
No description provided.
Summary: Intermittent browser_site_loading_background_test.js | Browser - Site loading background "before each" hook → Intermittent browser_site_loading_background_test.js | Browser - Site loading background validate loading background color
Assignee: nobody → apastor
Comment on attachment 8631110 [details] [review] [gaia] albertopq:1118637-intermitent-browser-loading > mozilla-b2g:master Sending the 'Enter' key input after the url instead of all together, seems to help: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b36c21fbd0f2778fdca9136157e99b8c29106080
Attachment #8631110 - Flags: review?(kgrandon)
Comment on attachment 8631110 [details] [review] [gaia] albertopq:1118637-intermitent-browser-loading > mozilla-b2g:master I am happy to see an intermittent go away, so thanks for working on this. Are you sure we should land it though? Seems to cause a bunch of intermittent failures: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b36c21fbd0f2778fdca9136157e99b8c29106080
Flags: needinfo?(apastor)
Attachment #8631110 - Flags: review?(kgrandon)
Comment on attachment 8631110 [details] [review] [gaia] albertopq:1118637-intermitent-browser-loading > mozilla-b2g:master Sorry, I was always sending the 'Enter' key on every enterText call, and I didn't think about cases in which we don't want to actually send it. Those were the ones that were failing. Fixed now. https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=57714212eb941d6a5ab93676a6df74b1e2d58e9e
Flags: needinfo?(apastor)
Attachment #8631110 - Flags: review?(kgrandon)
Comment on attachment 8631110 [details] [review] [gaia] albertopq:1118637-intermitent-browser-loading > mozilla-b2g:master Sounds good for me, seems weird that we need this but thank you for the fix!
Attachment #8631110 - Flags: review?(kgrandon) → review+
master: https://github.com/mozilla-b2g/gaia/commit/ad76c159c641c977d9140c5fedea84aea04e0e60
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: