Improve NetworkService debugging message

RESOLVED WONTFIX

Status

Firefox OS
RIL
RESOLVED WONTFIX
3 years ago
3 months ago

People

(Reporter: edgar, Unassigned)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
When reviewing bug 973543 and bug 1104664, I found the logging in NetworkService isn't clear enough for debugging.

In this bug, I would like to improve it.

e.g.

- Add logging when sending message to net_worker, http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkService.js#94-107

- The request id assignment looks a little strange, http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkService.js#99-103
IMO, we should always assign a valid id no matter the callback is available or not. Otherwise, we will see a lot of request and response with id=0, and it's hard to map them together.

- The response always contains a lot attribute because we assign every attribute with a default value in NetworkOptions.webidl. How about make them all optional and only construct it when it is really needed, though I don't know if it is possible.
(Reporter)

Updated

3 years ago
Blocks: 904514
(Reporter)

Comment 1

3 years ago
Created attachment 8551182 [details] [diff] [review]
WIP, Part 1: Improve NetworkService debugging message, v1
(Reporter)

Comment 2

3 years ago
Created attachment 8551183 [details] [diff] [review]
WIP, Part 2: Remove unused response attribute, v1
(Reporter)

Comment 3

3 years ago
Created attachment 8551185 [details] [diff] [review]
WIP, Part 3: Unify the attributes for the network command result, v1
(Reporter)

Updated

3 years ago
Depends on: 1123328
(Reporter)

Updated

3 years ago
Depends on: 1172307
(Reporter)

Updated

3 years ago
Depends on: 977474
(Reporter)

Updated

3 years ago
Depends on: 1041397
[Tracking Requested - why for this release]:
tracking-b2g: --- → backlog

Comment 5

3 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.