Closed Bug 111872 Opened 23 years ago Closed 23 years ago

Percentage height textarea grows with each keystroke

Categories

(Core :: Layout: Tables, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.7

People

(Reporter: gregvalure, Assigned: karnaze)

Details

(Keywords: testcase, Whiteboard: PATCH, CANDIDATE_094)

Attachments

(4 files, 2 obsolete files)

As seen in the testcase, if you have a textarea that has a height near 100%, it
will grow by two pixels with each keystroke.  This doesn't happen with fixed
heights.

2001112203 Win98

CCing karnaze since he's dealing with percentage heights.
Attached file testcase
happens with linux 2001-11-23-08 as well
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 98 → All
Hardware: PC → All
Eric, it looks like all the work is bing done in nsBoxFrame.cpp
Assignee: rods → evaughan
also seen on macOS 10
Keywords: testcase
taking the bug.
Assignee: evaughan → karnaze
Component: HTML Form Controls → HTMLTables
Priority: -- → P2
Target Milestone: --- → mozilla0.9.7
forms.css gives textareas a default 1 pixel top and bottom margin which
aggravated the bug. This test case exaggarates the problem.
Attachment #59429 - Attachment is obsolete: true
Comment on attachment 59431 [details] [diff] [review]
patch to fix the bug

r= alexsavulov
Attachment #59431 - Flags: review+
Comment on attachment 59431 [details] [diff] [review]
patch to fix the bug

sr=attinasi
Attachment #59431 - Flags: review+ → superreview+
Status: NEW → ASSIGNED
Whiteboard: PATCH, CANDIDATE_094
The patch is in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reopening.  The patch fixes the bug when the cell height is in TD, but not when
the height is in TR or there is a nested table.  2001-12-03-03 Win98
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file more testcases
Comment on attachment 59430 [details]
test case with a larger top margin on the textarea.

This is handled in bug 114430
Attachment #59430 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Comment on attachment 61090 [details] [diff] [review]
patch to fix additional test cases

r= alexsavulov
Attachment #61090 - Flags: review+
Comment on attachment 61090 [details] [diff] [review]
patch to fix additional test cases

sr=attinasi
Attachment #61090 - Flags: superreview+
The patch is in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
verified fixed on trunk build - winXP, linux  and macos 10.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: