Update deployment etc. for use with Python 2.7

VERIFIED FIXED

Status

www.mozilla.org
Bedrock
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: pmac, Unassigned)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1623666] )

User Story

* Adjust https://github.com/mozilla/bedrock/tree/master/bin/update scripts to call proper python
  - See https://github.com/mozilla/fjord/commit/6f4eb86f15f1fc31fc892e421adb28e015ce6474 for example
* Adjust https://github.com/mozilla/bedrock/tree/master/etc/cron.d to call proper python
  - Ideally via PYTHON_PATH provided by Chief... would require this to be some form of template.
  - Alternatively, a simple duplicate hard-coding of what's in commander_settings.py

Attachments

(1 attachment)

We need to update some things to use an alternate python. See steps in user story field.
According to the above and the example in fjord, the enviroinment variable into which you're putting the path to the proper Python is PYTHON_PATH. This seems confusingly close to PYTHONPATH which python itself uses as its package search path[0]. How married to this are you? Can we use something a bit more unique like PYTHON_BIN? I don't really care I think, but I'm worried about confusion in future.

[0] https://docs.python.org/2/using/cmdline.html#envvar-PYTHONPATH
Flags: needinfo?(nmaul)
Whiteboard: [kb=1623666]
Created attachment 8546036 [details] [review]
Link to Github pull-request: https://github.com/mozilla/bedrock/pull/2629

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e9266ade1f63419aa79a9f0fcc133ccbf0694069
Bug 1118786: Prep deployment and crons for Python 2.7

https://github.com/mozilla/bedrock/commit/b9bc8c6483710ef7c594b1a4cea36623cfef20cf
Merge pull request #2629 from pmclanahan/python-2.7-1118786

Bug 1118786: Prep deployment and crons for Python 2.7

Comment 4

3 years ago
Per the NEEDINFO in comment 1, I don't particularly care at all. On the other hand, this is already deployed and working, so........
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(nmaul)
Resolution: --- → FIXED
Oh yeah! Sorry about leaving this like this Jake. I was confusing env vars with settings vars in commander_settings.py. Thanks for ignoring this :)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.