Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku

RESOLVED FIXED in mozilla37

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1117034
(Assignee)

Comment 1

3 years ago
Created attachment 8545309 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code
Attachment #8545309 - Flags: review?(amarchesini)
Comment on attachment 8545309 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code

Review of attachment 8545309 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/crypto/WebCryptoTask.cpp
@@ +2103,5 @@
>      ATTEMPT_BUFFER_ASSIGN(mKeyData, PK11_GetKeyData(symKey));
>      return NS_OK;
>    }
>  
> +  virtual void Resolve() MOZ_OVERRIDE {

{ in a new line.

@@ +2108,5 @@
>      mKey->SetSymKey(mKeyData);
>      mResultPromise->MaybeResolve(mKey);
>    }
>  
> +  virtual void Cleanup() MOZ_OVERRIDE {

here too

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +2931,5 @@
>      nsTArray<nsString> emptyOptions;
>      return nsContentPermissionUtils::CreatePermissionArray(type, access, emptyOptions, aTypes);
>    }
>  
> +  NS_IMETHOD GetPrincipal(nsIPrincipal * *aRequestingPrincipal) MOZ_OVERRIDE

nsIPrincipal**

@@ +2937,5 @@
>      NS_IF_ADDREF(*aRequestingPrincipal = mPrincipal);
>      return NS_OK;
>    }
>  
> +  NS_IMETHOD GetWindow(nsIDOMWindow * *aRequestingWindow) MOZ_OVERRIDE

nsIDOMWindow**

@@ +2943,5 @@
>      NS_IF_ADDREF(*aRequestingWindow = mWindow);
>      return NS_OK;
>    }
>  
> +  NS_IMETHOD GetElement(nsIDOMElement * *aRequestingElement) MOZ_OVERRIDE

nsIDOMElement**

::: dom/mobileconnection/ipc/MobileConnectionParent.h
@@ +35,5 @@
>      MOZ_COUNT_DTOR(MobileConnectionParent);
>    }
>  
>    virtual void
> +  ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE;

aWhy

@@ +151,5 @@
>      MOZ_COUNT_DTOR(MobileConnectionRequestParent);
>    }
>  
>    virtual void
> +  ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE;

aWhy

::: dom/mobilemessage/ipc/SmsParent.h
@@ +43,5 @@
>      MOZ_COUNT_DTOR(SmsParent);
>    }
>  
>    virtual void
> +  ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE;

aWhy

::: dom/notification/DesktopNotification.h
@@ +151,5 @@
>  
>    NS_IMETHODIMP
>    Observe(nsISupports *aSubject,
>            const char *aTopic,
> +          const char16_t *aData) MOZ_OVERRIDE

type* aFoo

::: dom/telephony/ipc/TelephonyParent.h
@@ +25,5 @@
>  protected:
>    virtual ~TelephonyParent() {}
>  
>    virtual void
> +  ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE;

aWhy

@@ +97,5 @@
>    TelephonyRequestParent();
>    virtual ~TelephonyRequestParent() {}
>  
>    virtual void
> +  ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE;

aWhy
Attachment #8545309 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/238eeecce596
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.