Closed Bug 1118804 Opened 5 years ago Closed 5 years ago

Handle uncaught promise rejections in the inspector

Categories

(DevTools :: Inspector, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: ejpbruel, Assigned: ejpbruel)

References

Details

Attachments

(1 file)

Attempting to replace the deprecated-sync-thenables with Promise.jsm promises in protocol.js (bug 1096490) uncovered some uncaught promise rejections in the inspector. These need to be fixed before I can land the former.
Small patch. This should be enough to fix the problem.
Attachment #8545311 - Flags: review?(pbrosset)
Comment on attachment 8545311 [details] [diff] [review]
Handle uncaught promise rejections

Review of attachment 8545311 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8545311 - Flags: review?(pbrosset) → review+
Try push so RyanVM won't try to murder me when I land this again:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cab035465f90
Don't be so sure about that!
Try push is green, so here's another go at it:
https://hg.mozilla.org/integration/fx-team/rev/baf96433f2af
https://hg.mozilla.org/mozilla-central/rev/baf96433f2af
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.