Loop: click to add Hello icon to toolbar

RESOLVED FIXED in Firefox 36



3 years ago
3 years ago


(Reporter: ckprice, Assigned: Dolske)


36 Branch
Firefox 38

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed, firefox38 fixed)


(Whiteboard: [UITour:P1])


(1 attachment, 1 obsolete attachment)

Please add the ability to click to add the Hello icon from the customization palette to the toolbar. This will be used in campaigns for GA 36.
See Also: → bug 1071238


3 years ago
Whiteboard: [UITour:P1]

Comment 1

3 years ago
Created attachment 8550556 [details] [diff] [review]
Patch v.1

I won't lie -- I didn't actually test it because it's trivial. :)
Assignee: nobody → dolske
Attachment #8550556 - Flags: review?(MattN+bmo)
Comment on attachment 8550556 [details] [diff] [review]
Patch v.1

Review of attachment 8550556 [details] [diff] [review]:

r=me if you add the widgetName and do a manual test.

::: browser/components/uitour/UITour.jsm
@@ +120,5 @@
>        allowAdd: true,
>      }],
> +    ["loop",        {
> +      query: "#loop-button",
> +      allowAdd: true,

I think this isn't enough because you need widgetName so we know which widget to add:
"addNavBarWidget: can't add a widget without a widgetName property"

I didn't test it either though. You should be able to run Mozilla.UITour.addNavBarWidget("loop"); from the Web Console of the Loop tour to test.

BTW. the properties of the objects in the map were sorted alphabetically (other than "forget").
Attachment #8550556 - Flags: review?(MattN+bmo) → review+

Comment 3

3 years ago
Created attachment 8555495 [details] [diff] [review]
Patch v.2

Added widgetName, made props alphabetical (and fixed the forget button ordering), and did a manual test:

0) New profile, remove Hello button from toolbar.
1) Open https://www.mozilla.org/en-US/firefox/38.0a1/firstrun/
2) In web console, execute:
  Mozilla.UITour.addNavBarWidget("loop", function() { console.log("added") })
3) Button was added to toolbar, callback was invoked.
Attachment #8550556 - Attachment is obsolete: true
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Comment on attachment 8555495 [details] [diff] [review]
Patch v.2

Approval Request Comment
[Feature/regressing bug #]: Bug 1118874 - Hello tour/snippet/product page for 36
[User impact if declined]: Tour pages cannot help the user add the Hello button to their toolbar.
[Describe test coverage new/current, TreeHerder]: This functionality was tested for the Forget button before.
[Risks and why]: Low risk isolated to UITour. Worst case www.mozilla.org just doesn't use problematic APIs.
[String/UUID change made/needed]: None

RyanVM/others: Note that I will do uplifts myself since there are many UITour patches to uplift in the correct order.
Attachment #8555495 - Flags: review+
Attachment #8555495 - Flags: approval-mozilla-beta?
Attachment #8555495 - Flags: approval-mozilla-aurora?
status-firefox37: --- → affected
status-firefox38: --- → fixed
Attachment #8555495 - Flags: approval-mozilla-beta?
Attachment #8555495 - Flags: approval-mozilla-beta+
Attachment #8555495 - Flags: approval-mozilla-aurora?
Attachment #8555495 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.