1118835 - Consider adding back pref to show title in toolbar

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[:Margaret Leibovic]

There's some debate as to whether or not the decision to remove this pref in bug 1111729 was correct. We should decide whether or not to add it back.

I can start with a patch to add back the strings, in case we can't reach a decision about this before the aurora merge.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think we should add the pref back for Mobile but it might not be necessary for Tablet since there are now tabs on top (which actually show the Page Title).

Then, we just need to decide on a sensible default. Either way, monitoring the telemetry/ feedback about this specific setting would be a good idea going forward.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1118835/margaret

Comment 3

[:Margaret Leibovic]

/r/2113 - Bug 1118835 - Add back pref to show title in urlbar

Pull down this commit:

hg pull review -r 74cbb4b0dad35e5b637de1abfdafd092bdf86b58

Comment 4

[:Margaret Leibovic]

This patch is basically a backout of the patch in bug 1111729, minus the test changes, and with a default flip in mobile.js.

However, I just realized that I should probably also add back testTitleBar.

If we decide to go ahead and land this, I can also just back out the patch from bug 1117841.

Comment 5

[:Margaret Leibovic]

/r/2113 - Bug 1118835 - Add back pref to show title in urlbar
/r/2115 - Bug 1118835 - Add back (and update) testTitleBar

Pull down these commits:

hg pull review -r 431e777e838a274d7824b2c7a9bca62a1dcb6a1a

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/2111/#review1343

Looks like a good "backout" with some tweaks to not display on tablets.

Comment 7

[:Margaret Leibovic]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=697e263bb802

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/cce47fbfe2fc
https://hg.mozilla.org/integration/fx-team/rev/6c10a8ad2e7b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cce47fbfe2fc
https://hg.mozilla.org/mozilla-central/rev/6c10a8ad2e7b

Comment 10

[Aaron Train [:aaronmt]]

Where was the discussion for reconsideration?

Comment 11

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #10)
> Where was the discussion for reconsideration?

I just decided to do it based off of antlam's opinion in comment 1. We can have a discussion if we think it should be removed, but that's easier to do after the merge than adding it back.

Comment 12

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/4b1ab47fec93

Comment 13

[Teodora Vermesan (:TeoVermesan)]

"Title bar" option is present in Display sub-menu from Settings and works as expected, so:
Verified as fixed on:
Device: Alcatel One Touch (Android 4.1.2)
Build:Firefox for Android 38.0a1 (2015-01-15)

Comment 15

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1118835 - Add back pref to show title in urlbar

Comment 16

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1118835 - Add back (and update) testTitleBar