Closed Bug 1118835 Opened 5 years ago Closed 5 years ago

Consider adding back pref to show title in toolbar

Categories

(Firefox for Android :: General, defect)

35 Branch
All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 37
Tracking Status
fennec 37+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(2 files, 1 obsolete file)

There's some debate as to whether or not the decision to remove this pref in bug 1111729 was correct. We should decide whether or not to add it back.

I can start with a patch to add back the strings, in case we can't reach a decision about this before the aurora merge.
OS: Mac OS X → Android
Hardware: x86 → All
I think we should add the pref back for Mobile but it might not be necessary for Tablet since there are now tabs on top (which actually show the Page Title).

Then, we just need to decide on a sensible default. Either way, monitoring the telemetry/ feedback about this specific setting would be a good idea going forward.
Attachment #8545409 - Flags: review?(mark.finkle)
/r/2113 - Bug 1118835 - Add back pref to show title in urlbar

Pull down this commit:

hg pull review -r 74cbb4b0dad35e5b637de1abfdafd092bdf86b58
This patch is basically a backout of the patch in bug 1111729, minus the test changes, and with a default flip in mobile.js.

However, I just realized that I should probably also add back testTitleBar.

If we decide to go ahead and land this, I can also just back out the patch from bug 1117841.
/r/2113 - Bug 1118835 - Add back pref to show title in urlbar
/r/2115 - Bug 1118835 - Add back (and update) testTitleBar

Pull down these commits:

hg pull review -r 431e777e838a274d7824b2c7a9bca62a1dcb6a1a
Attachment #8545409 - Flags: review?(mark.finkle) → review+
https://reviewboard.mozilla.org/r/2111/#review1343

Looks like a good "backout" with some tweaks to not display on tablets.
https://hg.mozilla.org/mozilla-central/rev/cce47fbfe2fc
https://hg.mozilla.org/mozilla-central/rev/6c10a8ad2e7b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Where was the discussion for reconsideration?
(In reply to Aaron Train [:aaronmt] from comment #10)
> Where was the discussion for reconsideration?

I just decided to do it based off of antlam's opinion in comment 1. We can have a discussion if we think it should be removed, but that's easier to do after the merge than adding it back.
tracking-fennec: ? → 37+
"Title bar" option is present in Display sub-menu from Settings and works as expected, so:
Verified as fixed on:
Device: Alcatel One Touch (Android 4.1.2)
Build:Firefox for Android 38.0a1 (2015-01-15)
Status: RESOLVED → VERIFIED
Attachment #8545409 - Attachment is obsolete: true
Attachment #8619057 - Flags: review+
Attachment #8619058 - Flags: review+
You need to log in before you can comment on or make changes to this bug.