Closed
Bug 1118883
Opened 9 years ago
Closed 9 years ago
Autophone - upload crash dmp files to S3
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
Details
Attachments
(1 file)
|
10.89 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
As a follow up to bug 1080783, we should upload the crash dmp files to S3.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8545457 -
Flags: review?(mcote)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8545457 [details] [diff] [review] bug-1118883-v1.patch Review of attachment 8545457 [details] [diff] [review]: ----------------------------------------------------------------- ::: autophonecrash.py @@ +173,4 @@ > break > return exception > > + def _process_dump_file(self, path, extra, symbols_path, stackwalk_binary, clean=True): Are you using clean as True somewhere in testing? It seems that it's always False now.
Attachment #8545457 -
Flags: review?(mcote) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
You're right. I'm only using False for now in Autophone but that conflicts with the original usage in mozcrash.py which always unlinks the dump files. Initially I totally removed the unlinking of the dump files but then thought better of it and added clean just to keep some semblance of compatibility with mozcrash.py.
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://github.com/mozilla/autophone/commit/1496635c6dfaaf502d20d184df8a14cbaf5c5e5d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•