1118884 - [RTL][Cost Control] The date on the System's page is being cutoff on the right side of the screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: MonthCutoffinSystem.jpg

Description:
The date on the System's page is being cutoff on the right side of the screen. 

Repro Steps:
1)  Updated Flame to Build ID: 20150107010216
2)  Change the language to "Arabic" in settings.
3)  Tap on the "Usage" app. 
4)  Proceed through the setup until reaching the "Usage" page.
5)  Tap on "System" under "Mobile App Usage".
6)  Observe the month "Feb" to the right of the screen under the data graph.

Actual:
The month "Feb" is being cutoff on the right side of the screen.

Expected:
The abbreviation "Feb" is not cutoff under System.

Environmental Variables
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20150107010216
Gecko: https://hg.mozilla.org/mozilla-central/rev/33781a3a5201
Gaia: 69ac77cfa938fae2763ac426a80ca6e5feb6ad25
Platform Version: 37.0a1
Firmware Version: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Notes:
Repro frequency: 5/5 100%
See attached: screenshot

Comment 1

[Augustin Trancart [:autra]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27884

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8558627 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27884

Marina, could you review this bug, please? Thank you!

Comment 3

[Marina Rodríguez [:mai]]

Comment on attachment 8558627 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27884

LGTM. Thanks!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Removing blocking flag as it's not needed for RTL bugs.

Please ask for approval for 2.2

Comment 5

[Augustin Trancart [:autra]]

Comment on attachment 8558627 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27884

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Lack of RTL support
[User impact] if declined: In RTL language the date on the cost control string can't be entirely read
[Testing completed]: On flame 2.2
[Risk to taking this patch] (and alternatives if risky): Moderate, only trivial change to canvas alignment.
[String changes made]: None

Comment 6

[Dylan Oliver [:doliver]]

Marina, can we land this on master & resolve it?

Comment 7

[Marina Rodríguez [:mai]]

yes, you can land the patch on master.

Comment 8

[bhavana bajaj [:bajaj]]

waiting for master landing here before getting this on the branch.

Comment 9

[Marina Rodríguez [:mai]]

Master: 63d943d4e36b281679ada4d826f2cf96c7e7f474

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/305399c91cb95ee850ec434f1d9cb85c203facd0

Comment 11

[SandKing]

Hi KTucker,
What should we do will make the System displayed? 
I made a lot of operation, but most of them were classed as Others or the AP's name(Email/Homescreen/Smart Collections).

Comment 12

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding Shing to see if he can answer or find someone who can answer the question in comment 11

Comment 13

[Yeojin Chung [:YeojinC]]

This issue reproduces on today's Flame 2.2 nightly build.

Result: The keyboard disappears after entering a letter in the rocket bar.

Result: Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 14

[Yeojin Chung [:YeojinC]]

(In reply to Yeojin Chung [:YeojinC] from comment #13)
> This issue reproduces on today's Flame 2.2 nightly build.
> 
> Result: The keyboard disappears after entering a letter in the rocket bar.
> 
> Result: Device: Flame 2.2 (KK, 319mb, full flash)
> Build ID: 20150223002503
> Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
> Gecko: 9fd3441c8983
> Gonk: e7c90613521145db090dd24147afd5ceb5703190
> Version: 37.0a2 (2.2)
> Firmware Version: v18D-1
> User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Please ignore this comment. I was working on a different bug. Sorry about the mess.

Comment 15

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: The month is not cut off from the screen under mobile usage per app screen.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150223010224
Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633
Gecko: 86d2bb8bb1c9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 16

[Shing Lyu [:shinglyu]]

(In reply to SandKing from comment #11)

The "System" category was renamed to "Others" in bug 1125791

> Hi KTucker,
> What should we do will make the System displayed? 
> I made a lot of operation, but most of them were classed as Others or the
> AP's name(Email/Homescreen/Smart Collections).