Make "make clean" clean out node_modules

RESOLVED FIXED

Status

Webtools
DXR
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: erik, Unassigned)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: easy)

(Reporter)

Description

4 years ago
We run our tests on Jenkins, and Jenkins keeps a workspace (a checkout of the code) around between runs. This allows the installed npm packages, which live in node_modules, to leak from run to run, meaning we can't take Jenkins' word for it that a paring down of our npm dependencies was okay. (The motivating case here was an attempt to do an npm install --production in order to avoid installing a pointless phantomjs.) jenkins.sh already runs "make clean". If we make "make clean" clear out the non-git-tracked items from the node_modules dir, it should restore testrun independence.
(Reporter)

Comment 1

3 years ago
"make clean" now cleans out nunjucks, which is the only npm module we install directly. Since npm nests subdependencies inside that folder, they get deleted too. Also, we now have Jenkins clear its workspace before each run.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.