Closed
Bug 1118983
Opened 9 years ago
Closed 9 years ago
Mozilla logo at bottom of Standalone UI is incorrect
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: sevaan, Assigned: aaronraimist, Mentored)
Details
(Whiteboard: [lang=js][good first bug])
Attachments
(2 files)
2.89 KB,
image/png
|
Details | |
3.76 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
The kerning in the Mozilla logo in the footer of the Standalone UI is incorrect. The incorrect logo is on the left here: http://cl.ly/image/3X1q442j2T1X You can see the difference in the spacing between the letters. Please replace the asset with the one attached.
Comment 1•9 years ago
|
||
Implementation steps: - Replace the mozilla-logo.png in the source with the one in attached to this bug (attachment 8545481 [details]) -- xref http://mxr.mozilla.org/mozilla-central/find?text=&string=mozilla-logo.png - Check the Standalone UI still has a good layout. See https://wiki.mozilla.org/Loop/Development#Standalone_server_-_Link-clicker_UI_and_unit_test_development for how to do this. - Submit the patch if all is fine.
Mentor: standard8
Whiteboard: [lang=js][good first bug]
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8604978 -
Flags: review?(standard8)
Comment 3•9 years ago
|
||
Comment on attachment 8604978 [details] [diff] [review] bug1118983_loopmozillalogo.diff Thanks for the patch, this looks great. The only thing you might want to consider in future is including a commit message.
Attachment #8604978 -
Flags: review?(standard8) → review+
Comment 4•9 years ago
|
||
I'll land this in a couple of minutes.
Assignee: nobody → aaronraimist
Flags: qe-verify-
Flags: firefox-backlog+
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/f5d4f0d1fed9
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•