1119037 - Fetch API: Add Request context attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

The context is what initiated the load (stylesheet, image etc.). Internally we have a nsContentPolicyType, which may not cover what the spec says, but we use for CSP.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Turns out there isn't a direct mapping from RequestContext to nsContentPolicyType since we often need more information (is window top level?, is this channel loaded to due a link?) to determine the exact CSP behaviour to apply to a fetch. Seems like the fetch interception code will have to set this as best as it can, and then map it back to CSP later in FetchDriver (or InternalRequest could hold the original channel's nsContentPolicyType). Repurposing this bug to just add the WebIDL property.

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: bz://1119037/nsm

/r/3061 - Bug 1119037 - Add context attribute to Request. r=baku

Pull down this commit:

hg pull review -r 404f5e20259d145ba10ae3b658e93127cb363384

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This removes ContextFrameType since it isn't exposed to content and does not help internally. Right now Request::mContext is only for content to get a valid value (always set to "fetch"), which can be set to good defaults when the network interception code creates a Request.

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8555536 [details]
MozReview Request: bz://1119037/nsm

/r/3061 - Bug 1119037 - Add context attribute to Request. r=baku
/r/3063 - Bug 1124638 - Allow chrome to set Request context.

Pull down these commits:

hg pull review -r 2795af895358bf112207e8c855aebfcd22117087

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ac6715d8224

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4ac6715d8224

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1119037 - Add context attribute to Request. r=baku

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1124638 - Allow chrome to set Request context.