Closed
Bug 1119142
Opened 9 years ago
Closed 9 years ago
[NFC] current test cases fail on nightly
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
Attachments
(1 file)
with test on nightly, Error shows mozbluetooth should be changed via Object.defineProperty in nfc_manager, and MockMozNfc is not defined in nfc_handover_manager
Assignee | ||
Comment 1•9 years ago
|
||
WIP
Assignee | ||
Updated•9 years ago
|
Summary: [NFC] current test cases not testable on nightly → [NFC] current test cases fail on nightly
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gasolin
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8545784 [details] [review] pull request redirect to github test change only, test green. The reason of nfc_handover_manager test fail is not related to the original thought (mozNfc become get only on nightly), but the mockMozNFC is been 'compromised' in nfc_handover_manager's test. Since we are moving to BTv2 API and not willing to change these old code (and nfc related refactor work is going on by george), I think wrap mockMozNFC to module pattern is the sufficient fix for passing all test cases.
Attachment #8545784 -
Flags: review?(alive)
Updated•9 years ago
|
Attachment #8545784 -
Flags: review?(alive) → review+
Assignee | ||
Comment 4•9 years ago
|
||
forget to link with autoland-bot /o\ merged https://github.com/mozilla-b2g/gaia/commit/6b05971a3a27637502022f923cc328aec3504aa9 thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•