Font preview isn't updated when theme changes

RESOLVED FIXED in Firefox 41

Status

defect
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: Honza, Assigned: sjakthol)

Tracking

unspecified
Firefox 41
x86_64
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

STR:
1. Load http://nightly.mozilla.org/
2. Open the toolbox, activate the Light theme
3. Select the Inspector panel, inspect "nightly-title" on the page
4. Select the Fonts side panel. The font-preview foreground color is black
5. Go to the Options panel and activate Dark theme
6. Go back to the Inspector panel. The font-preview foreground color is still black -> BUG it should be white

If you change selection in the Inspector panel the font-preview is properly updated.
Assignee

Comment 1

4 years ago
Here's a patch that makes the previews to update when the theme changes. This patch requires the patch from bug 1169993 for the test to work properly.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e28d053db87
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8613867 - Flags: review?(pbrosset)
Assignee

Updated

4 years ago
Depends on: 1169993
Comment on attachment 8613867 [details] [diff] [review]
bug-1119149-font-inspector-theme-change.patch

Review of attachment 8613867 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work, very simple, I like the test, easy to read.
Attachment #8613867 - Flags: review?(pbrosset) → review+
Assignee

Comment 3

4 years ago
The patches from bug 1169993 need to land with this one or this patch causes a perma-orange.
Keywords: checkin-needed
(In reply to Sami Jaktholm from comment #3)
> The patches from bug 1169993 need to land with this one or this patch causes
> a perma-orange.

Do they need to land together, or is it just that 1169993 needs to land first?
Assignee

Comment 5

4 years ago
(In reply to Brian Grinstead [:bgrins] from comment #4)
> (In reply to Sami Jaktholm from comment #3)
> > The patches from bug 1169993 need to land with this one or this patch causes
> > a perma-orange.
> 
> Do they need to land together, or is it just that 1169993 needs to land
> first?

First or at the same time, doesn't really matter. If there's a working setTheme method available, the test works. If not, the test times out.
https://hg.mozilla.org/mozilla-central/rev/dd80c9d55129
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.