1119149 - Font preview isn't updated when theme changes

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:
1. Load http://nightly.mozilla.org/
2. Open the toolbox, activate the Light theme
3. Select the Inspector panel, inspect "nightly-title" on the page
4. Select the Fonts side panel. The font-preview foreground color is black
5. Go to the Options panel and activate Dark theme
6. Go back to the Inspector panel. The font-preview foreground color is still black -> BUG it should be white

If you change selection in the Inspector panel the font-preview is properly updated.

Comment 1

[Sami Jaktholm]

Attachment: bug-1119149-font-inspector-theme-change.patch

Here's a patch that makes the previews to update when the theme changes. This patch requires the patch from bug 1169993 for the test to work properly.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e28d053db87

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8613867 [details] [diff] [review]
bug-1119149-font-inspector-theme-change.patch

Review of attachment 8613867 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work, very simple, I like the test, easy to read.

Comment 3

[Sami Jaktholm]

The patches from bug 1169993 need to land with this one or this patch causes a perma-orange.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Sami Jaktholm from comment #3)
> The patches from bug 1169993 need to land with this one or this patch causes
> a perma-orange.

Do they need to land together, or is it just that 1169993 needs to land first?

Comment 5

[Sami Jaktholm]

(In reply to Brian Grinstead [:bgrins] from comment #4)
> (In reply to Sami Jaktholm from comment #3)
> > The patches from bug 1169993 need to land with this one or this patch causes
> > a perma-orange.
> 
> Do they need to land together, or is it just that 1169993 needs to land
> first?

First or at the same time, doesn't really matter. If there's a working setTheme method available, the test works. If not, the test times out.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dd80c9d55129

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd80c9d55129