1119220 - TraceLogger: Fix start/stop messages

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

The start/stop messages don't always correspond anymore, due to a change a made to fix a windows bug.

This fixes it again.

(found it by a new check I added. Will open a bug to include that eventually)

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

Give the IonMonkey start events before doing the arguments checks, which could bail.

Comment 2

[Hannes Verschore [:h4writer]]

Attachment: Patch

Forgot to update the other architectures.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8546535 [details] [diff] [review]
Patch

Review of attachment 8546535 [details] [diff] [review]:
-----------------------------------------------------------------

OK to not block on this particular one, but please open a follow up for erasing all this code duplication in the future... (and as said on irc, code duplication the generateEpilogue() could be avoided as well)

Comment 4

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/335c09bb1c95

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/335c09bb1c95

Comment 6

[Hannes Verschore [:h4writer]]

Comment on attachment 8546535 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]:
Bug 1071546

[User impact if declined]:
Not much impact for regular users. It might annoy few people that they need to wait another release before tracelogger is working well. This just missed the merge, so a bit of a bummer.

[Describe test coverage new/current, TBPL]:
1 day on Inbound.

[Risks and why]: 
Very small risk. Small patch and only used by select public

[String/UUID change made/needed]:
/

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8546535 [details] [diff] [review]
Patch

Aurora+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/305d94d1ba09