1119228 - Fix a fatal warning in PossiblyFail; r=jandem

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[(no longer active)]

Recent clang emits the following warning (which is treated as an error) on this code:
error: implicit conversion of nullptr constant to 'bool' [-Werror,-Wnull-conversion]

Comment 1

[(no longer active)]

Attachment: Fix a fatal warning in PossiblyFail

Comment 2

[André Bargull [:anba]]

dup of bug 1108155?

Comment 3

[Jan de Mooij [:jandem]]

(In reply to André Bargull from comment #2)
> dup of bug 1108155?

Oh you're right. I did remember reviewing a similar patch before but thought it was another macro, but the other patch just didn't land yet...

Comment 4

[Jan de Mooij [:jandem]]

Hm the other patch might be slightly nicer, I think we can push it for Jason if it fixes your build. Or ping him to do it.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bcacb5692ad9

Comment 6

[(no longer active)]

Sorry, I didn't see the previous comments before landing.  What should I do here?

Comment 7

[Jan de Mooij [:jandem]]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #6)
> Sorry, I didn't see the previous comments before landing.  What should I do
> here?

I think your patch is fine and we don't need to do anything.