Recent clang emits the following warning (which is treated as an error) on this code: error: implicit conversion of nullptr constant to 'bool' [-Werror,-Wnull-conversion]
Attachment #8545923 - Flags: review?(jdemooij) → review+
dup of bug 1108155?
(In reply to André Bargull from comment #2) > dup of bug 1108155? Oh you're right. I did remember reviewing a similar patch before but thought it was another macro, but the other patch just didn't land yet...
Hm the other patch might be slightly nicer, I think we can push it for Jason if it fixes your build. Or ping him to do it.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Sorry, I didn't see the previous comments before landing. What should I do here?
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #6) > Sorry, I didn't see the previous comments before landing. What should I do > here? I think your patch is fine and we don't need to do anything.
You need to log in before you can comment on or make changes to this bug.