1119235 - Http.jsm should be passing null to xhr.send if there is no postData, not an empty string

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Mike Kaply [:mkaply]]

I was attempting to use Http.jsm to execute a DELETE function on a server, but it was not working correctly.

The reason is because Http.jsm passes "" when there is no postData, and the server sees this as content (and a content type is passed).

Http.jsm should be passing null when there is no postData.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: 1119235.diff

Use null instead of empty string when there is no post data.

Also, don't call isArray unnecessarily if there is no post data.

I considered updating the log message as well, but that seemed overkill.

Comment 2

[Mike Kaply [:mkaply]]

Patrick:

Wanted to make sure you saw this since I think this is your file?

Comment 3

[Patrick Cloke [:clokep]]

(In reply to Mike Kaply [:mkaply] from comment #2)
> Wanted to make sure you saw this since I think this is your file?

Thanks. This looks like the right change...otherwise to send no postdata you'd have to define it and set it to null...which is weird.

I CCed Florian who wrote this code originally though.

Comment 4

[Mike Kaply [:mkaply]]

> Thanks. This looks like the right change...otherwise to send no postdata you'd have to define it and set it to null...which is weird.

Actually, that won't work either because since postData isn't defined, you still end up with the "". I tried that :)

Comment 5

[Patrick Cloke [:clokep]]

Looks like the docs at [1] are just wrong then. Maybe we can add a test for this? :)

[1] https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/Http.jsm?from=Http.jsm#21

Comment 6

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f143f852ede1

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f143f852ede1