Wrong usage of getService in pref-masterpass.js

VERIFIED FIXED in psm2.2

Status

Core Graveyard
Security: UI
P1
normal
VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

1.0 Branch
psm2.2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
While reading code, I found what I believe is an error.

The code asks for the "service" nsIDialogParamBlock. But there is no such
service. Each dialog must use its own parameter block. By asking for the
service, I fear the application will reuse the parameter block of a different
dialog. And this will mess up the parameter block of the other dialog.

In order to fix this bug, the code must request a new instance.
(Assignee)

Comment 1

17 years ago
Assigning to myself.
Assignee: ssaux → kaie
Priority: -- → P1
Target Milestone: --- → 2.2
(Assignee)

Comment 2

17 years ago
I found another occurrence of this error in certManager.js
(Assignee)

Comment 3

17 years ago
Created attachment 59149 [details] [diff] [review]
Suggested fix
(Assignee)

Comment 4

17 years ago
Javi, can you please review?
Status: NEW → ASSIGNED

Comment 5

17 years ago
Comment on attachment 59149 [details] [diff] [review]
Suggested fix

r=javi
Attachment #59149 - Flags: review+
(Assignee)

Comment 7

17 years ago
checked in, fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Verified per kaie's comment.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.