1119387 - Upload flame updates to balrog

Status: RESOLVED FIXED

(Taskcluster :: General, defect, P1)

Description

[James Lal [:lightsofapollo]]

Portions of this are handled by mozharness but in particular we need to configure the mar path (should be an artifact url) and embed credentials for balrog to the phone images.

See submit_to_balrog in mozharness/scripts/b2g_build.py 

Note- it is likely easier to start submitting these to staging balrog first as we likely need to proxy to inside the VPC to post to production balrog.

Comment 1

[Wander Lairson Costa]

Attachment: MozReview Request: bz://1119387/wcosta

/r/5601 - Bug 1119387 part 1: Move basic build setup to a separate script.
/r/5603 - Bug 1119387 part 2: Add flame nightly build script.
/r/5605 - Bug 1119387 part 3: Add option to specify mozharness branch.
/r/5607 - Bug 1119387 part 4: Validate only artifacts that can leak blobs.
/r/5609 - Bug 1119387 part 5: Update docker images.

Pull down these commits:

hg pull review -r b6ed96f6616e2df3a5659abb9700c3fdfbad50e4

Comment 2

[Wander Lairson Costa]

Attachment: MozReview Request: bz://1119387/wcosta

/r/5621 - Bug 1119387 part 1: Enable overriding of nightly build rules.
/r/5623 - Bug 1119387 part 2: Enable to pass balrog platform through command line.
/r/5625 - Bug 1119387 part 3: Allow the build configuration pass balrog username.
/r/5627 - Bug 1119387 part 4: Make buildbot properties optional.
/r/5629 - Bug 1119387 part 5: Setup branch name.
/r/5631 - Bug 1119387 part 6: Fix type error exception in upload method.
/r/5633 - Bug 1119387 part 7: Add nightly phone taskcluster build config.

Pull down these commits:

hg pull review -r 962f2aa6f8fa0be8ae24a7499caddad3f550b172

Comment 3

[Wander Lairson Costa]

Comment on attachment 8579395 [details]
MozReview Request: bz://1119387/wcosta

/r/5621 - Bug 1119387 part 1: Enable overriding of nightly build rules.
/r/5623 - Bug 1119387 part 2: Enable to pass balrog platform through command line.
/r/5625 - Bug 1119387 part 3: Allow the build configuration pass balrog username.
/r/5627 - Bug 1119387 part 4: Make buildbot properties optional.
/r/5629 - Bug 1119387 part 5: Setup branch name.
/r/5631 - Bug 1119387 part 6: Fix type error exception in upload method.
/r/5633 - Bug 1119387 part 7: Add nightly phone taskcluster build config.

Pull down these commits:

hg pull review -r 962f2aa6f8fa0be8ae24a7499caddad3f550b172

Comment 4

[Wander Lairson Costa]

There are two points on this patch:

1) As Taskcluster currently cannot talk to production Balrog, we are pushing updates to staging. As the balrog config in gecko tree is shared among other phones, flame updates will not work.

2) As Taskcluster cannot push symbols either, we disable breakpad symbols too.

Comment 5

[Wander Lairson Costa]

https://treeherder.allizom.org/#/jobs?repo=try&revision=7987139fa105

Comment 6

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/5607/#review4611

::: testing/docker/phone-builder/bin/validate_task.py
(Diff revision 1)
> -    if 'artifacts' in payload:
> +    locations = task["extra"]["locations"]

Hrm, so how does this prevent us from leaking things as a public artifact?  This is just a location that can be referenced later on, but not preventing something within the task from putting it into artifacts-public from what I can tell.

Comment 7

[James Lal [:lightsofapollo]]

I think we need to land better try permissions before we push this .. It might be pretty easy to get the backup folders as is since we allow just about anyone on try access to this worker type right now...

Comment 8

[Wander Lairson Costa]

(In reply to Greg Arndt [:garndt] from comment #6)
> https://reviewboard.mozilla.org/r/5607/#review4611
> 
> ::: testing/docker/phone-builder/bin/validate_task.py
> (Diff revision 1)
> > -    if 'artifacts' in payload:
> > +    locations = task["extra"]["locations"]
> 
> Hrm, so how does this prevent us from leaking things as a public artifact? 
> This is just a location that can be referenced later on, but not preventing
> something within the task from putting it into artifacts-public from what I
> can tell.

This has been discussed in irc.

Comment 9

[Wander Lairson Costa]

https://reviewboard.mozilla.org/r/5607/#review4647

> Hrm, so how does this prevent us from leaking things as a public artifact?  This is just a location that can be referenced later on, but not preventing something within the task from putting it into artifacts-public from what I can tell.

The issue is not related to this commit. We discussed that in irc and going to fix that in another bug.

Comment 10

[[e-mail] (:bhearsum)]

https://reviewboard.mozilla.org/r/5621/#review4649

I'm not sure about the architectural changes this patch is making. I think Jordan is a better reviewer than me for them....

Comment 11

[[e-mail] (:bhearsum)]

https://reviewboard.mozilla.org/r/5621/#review4651

::: configs/b2g/taskcluster-phone.py
(Diff revision 1)
> +        'submit-to-balrog'

One thing I will say though, is that I'm not sure we want Balrog submission for non-Nightly builds. Do you have Nightly builds for this configuration?

Comment 12

[[e-mail] (:bhearsum)]

https://reviewboard.mozilla.org/r/5623/#review4653

::: scripts/b2g_build.py
(Diff revision 1)
> +            self.set_buildbot_property("platform", self.config["platform"])

I think you should flip these around -- the config specified platform should override the properties.

Comment 13

[[e-mail] (:bhearsum)]

https://reviewboard.mozilla.org/r/5625/#review4655

::: mozharness/mozilla/updates/balrog.py
(Diff revision 1)
> +            product = None

This one is surprising to me. Product is required to submit to Balrog - the submitter can't generate the release name without it. How is balrog-submitter.py succeeding for you without it?

Comment 14

[[e-mail] (:bhearsum)]

https://reviewboard.mozilla.org/r/5633/#review4659

::: configs/b2g/taskcluster-phone-nightly.py
(Diff revision 1)
> +    "balrog_username": "stage-b2gbld",

It's generally a bad idea to specify dev or prod specific things such as the balrog api root and username in configs like this. Doing so means that you have to modify _build_ configs to run things in dev. We have these defined already in the balrog production.py/staging.py configs. You should pass one of those to your script in addition to this config -- Mozharness will layer them together. This probably removes the need for some of your changes to the BalrogMixin.

Comment 15

[[e-mail] (:bhearsum)]

Another thing to note is that we need to make sure we disable the buildbot Flame builds either completely, or just disable their Balrog uploading, prior to this landing. (I'm assuming these new builds are meant to take the place of them.)

Comment 16

[Greg Arndt [:garndt]]

Comment on attachment 8579384 [details]
MozReview Request: bz://1119387/wcosta

looks good, but now that we are not validating where artifacts get put, the img location validation doesn't really help and could be removed (that location isn't used to tell the task where to put something, it's just for reference by other tasks).

Also, the comments I had about the security of this image are being addressed in a separate bug and not related to this patch.  Nothing drastically changed in those regards with how things get to different places.

Comment 17

[Wander Lairson Costa]

https://reviewboard.mozilla.org/r/5621/#review4673

> One thing I will say though, is that I'm not sure we want Balrog submission for non-Nightly builds. Do you have Nightly builds for this configuration?

After talking to lightsofapollo in irc, I am going to drop this for now.

Comment 18

[Wander Lairson Costa]

Comment on attachment 8579384 [details]
MozReview Request: bz://1119387/wcosta

/r/5601 - Bug 1119387 part 1: Move basic build setup to a separate script.
/r/5603 - Bug 1119387 part 2: Add flame nightly build script.
/r/5605 - Bug 1119387 part 3: Add option to specify mozharness branch.
/r/5607 - Bug 1119387 part 4: Validate only artifacts that can leak blobs.
/r/5609 - Bug 1119387 part 5: Update docker images.

Pull down these commits:

hg pull review -r 7fe42dfaee7c4e246eb71d09e1601e92a0ba869b

Comment 19

[Wander Lairson Costa]

Comment on attachment 8579395 [details]
MozReview Request: bz://1119387/wcosta

/r/5621 - Bug 1119387 part 1: Enable to pass balrog platform through command line.
/r/5623 - Bug 1119387 part 2: Allow the build configuration pass balrog product.
/r/5625 - Bug 1119387 part 3: Make buildbot properties optional.
/r/5627 - Bug 1119387 part 4: Setup branch name.
/r/5629 - Bug 1119387 part 5: Fix type error exception in upload method.
/r/5631 - Bug 1119387 part 6: Add nightly phone taskcluster build config.

Pull down these commits:

hg pull review -r 006a15b11cb91478bfd533c8b46fbf37651781d6

Comment 20

[Wander Lairson Costa]

Comment on attachment 8579395 [details]
MozReview Request: bz://1119387/wcosta

/r/5621 - Bug 1119387 part 1: Enable to pass balrog platform through command line.
/r/5623 - Bug 1119387 part 2: Allow the build configuration pass balrog product.
/r/5625 - Bug 1119387 part 3: Make buildbot properties optional.
/r/5627 - Bug 1119387 part 4: Setup branch name.
/r/5629 - Bug 1119387 part 5: Fix type error exception in upload method.
/r/5631 - Bug 1119387 part 6: Add nightly phone taskcluster build config.

Pull down these commits:

hg pull review -r 006a15b11cb91478bfd533c8b46fbf37651781d6

Comment 21

[Wander Lairson Costa]

Comment on attachment 8579384 [details]
MozReview Request: bz://1119387/wcosta

/r/5601 - Bug 1119387 part 1: Move basic build setup to a separate script.
/r/5603 - Bug 1119387 part 2: Add flame nightly build script.
/r/5605 - Bug 1119387 part 3: Add option to specify mozharness branch.
/r/5607 - Bug 1119387 part 4: Validate only artifacts that can leak blobs.
/r/5609 - Bug 1119387 part 5: Update docker images.

Pull down these commits:

hg pull review -r 7fe42dfaee7c4e246eb71d09e1601e92a0ba869b

Comment 22

[Greg Arndt [:garndt]]

Comment on attachment 8579384 [details]
MozReview Request: bz://1119387/wcosta

https://reviewboard.mozilla.org/r/5599/#review4779

Ship It!

Comment 23

[[e-mail] (:bhearsum)]

Comment on attachment 8579395 [details]
MozReview Request: bz://1119387/wcosta

https://reviewboard.mozilla.org/r/5619/#review4803

::: mozharness/mozilla/updates/balrog.py
(Diff revisions 1 - 2)
>          c = self.config

It looks like product is unused here now. r=me if you stop passing it.

Comment 24

[[e-mail] (:bhearsum)]

https://reviewboard.mozilla.org/r/5619/#review4845

::: mozharness/mozilla/updates/balrog.py
(Diff revision 2)
> +            buildbot_properties = []

Just noticed this, you should set buildbot_properties to {} not []. Items returns a dict, not a list.

::: mozharness/mozilla/updates/balrog.py
(Diff revision 2)
> +

Can you raise an error if product is None after this point? It's not valid to submit a release without product, and could lead to bad things...

Comment 25

[Wander Lairson Costa]

Comment on attachment 8579395 [details]
MozReview Request: bz://1119387/wcosta

/r/5621 - Bug 1119387 part 1: Enable to pass balrog platform through command line.
/r/5623 - Bug 1119387 part 2: Allow the build configuration pass balrog product.
/r/5625 - Bug 1119387 part 3: Make buildbot properties optional.
/r/5627 - Bug 1119387 part 4: Setup branch name.
/r/5629 - Bug 1119387 part 5: Fix type error exception in upload method.
/r/5631 - Bug 1119387 part 6: Add nightly phone taskcluster build config.

Pull down these commits:

hg pull review -r c36fc18c533ae55bc82570e8908514f8b9d3681e

Comment 26

[[e-mail] (:bhearsum)]

Comment on attachment 8579395 [details]
MozReview Request: bz://1119387/wcosta

https://reviewboard.mozilla.org/r/5619/#review4853

Ship It!

Comment 27

[[e-mail] (:bhearsum)]

I landed the mozharness patch on default: https://hg.mozilla.org/build/mozharness/rev/e5c4329b818a

Comment 28

[Wander Lairson Costa]

https://hg.mozilla.org/integration/b2g-inbound/rev/a22c81667a6f
https://hg.mozilla.org/integration/b2g-inbound/rev/04a63a93948e
https://hg.mozilla.org/integration/b2g-inbound/rev/acb7171c4001
https://hg.mozilla.org/integration/b2g-inbound/rev/5e26607b7c1e
https://hg.mozilla.org/integration/b2g-inbound/rev/819ac6ae27e1

Comment 29

[Jordan Lund (:jlund)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 30

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a22c81667a6f
https://hg.mozilla.org/mozilla-central/rev/04a63a93948e
https://hg.mozilla.org/mozilla-central/rev/acb7171c4001
https://hg.mozilla.org/mozilla-central/rev/5e26607b7c1e
https://hg.mozilla.org/mozilla-central/rev/819ac6ae27e1

Comment 32

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 7: Add nightly phone taskcluster build config.

Comment 33

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 1: Enable to pass balrog platform through command line.

Comment 34

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 2: Allow the build configuration pass balrog product.

Comment 35

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 3: Make buildbot properties optional.

Comment 36

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 4: Setup branch name.

Comment 37

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 5: Fix type error exception in upload method.

Comment 38

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 6: Add nightly phone taskcluster build config.

Comment 40

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 5: Update docker images.

Comment 41

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 1: Move basic build setup to a separate script.

Comment 42

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 3: Add option to specify mozharness branch.

Comment 43

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 2: Add flame nightly build script.

Comment 44

[Wander Lairson Costa]

Attachment: MozReview Request: Bug 1119387 part 4: Validate only artifacts that can leak blobs.

Comment 45

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...