1119416 - Bugzilla still thinks I need to do a review after I've done it in reviewboard

Status: RESOLVED DUPLICATE of bug 1119430

(MozReview Graveyard :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I had a review requested from me via reviewboard in bug 1119302.

I went into reviewboard and did the review.  I had one comment, which I put in, leaving the default-checked "Open an issue" checkbox checked.  Then I checked the "Ship It" checkbox and published the review.

Now the reviewboard review is in the "Fix it, then Ship it!" state, as far as I can tell.  Also as far as I can tell I'm done here unless and until the patch author pushes back on my comment.  However the Bugzilla review request is still there, still showing up in my queries and generally getting in the way.  It should not be there anymore.

Basically, I need a way to be able to mark "r+ if you fix these things" in reviewboard and have that make the bugzilla review request go away.

Comment 1

[Mark Côté [:mcote]]

Explained fully in bug 1119430, but basically this is because child review requests don't get their own r? flags.  bsmedberg added the attachment and flag to bug 1119302 manually and why bz had to r+ it manually as well.