Port Bug 1118032 to TB [the word "Automatic" does not convey any information on what the choice actually does]

RESOLVED FIXED in Thunderbird 37.0

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 37.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

When bug 1118032 has his review I'll add the patch for TB.
Depends on: 1108198
Posted patch ColorUI.patch (obsolete) — Splinter Review
Patch as it landed for Firefox ported to TB.

This patch should land before the uplift because of the localization changes.
Attachment #8546829 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8546829 [details] [diff] [review]
ColorUI.patch

Review of attachment 8546829 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/locales/en-US/chrome/messenger/preferences/colors.dtd
@@ +5,5 @@
>  <!ENTITY  colorsDialog.title              "Colors">
>  <!ENTITY  window.width                    "38em">
>  <!ENTITY  window.macWidth                 "41em">
>  
> +<!ENTITY  overridePageColors.label        "Override the colors specified by the page with my selections above:">

I think we use content instead of page for thunderbird
Attachment #8546829 - Flags: review?(mkmelin+mozilla) → review+
Posted patch ColorUI.patchSplinter Review
Again the same error as in last bug. I'll never learn it :(
Attachment #8546829 - Attachment is obsolete: true
Attachment #8546852 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
Pushed http://hg.mozilla.org/comm-central/rev/4b97fba5d943 to fix the doubled <vbox>
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.