Link clicker UI no longer resets to the start conversation view after giving feedback

RESOLVED FIXED in mozilla37

Status

Hello (Loop)
Client
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({regression})

unspecified
mozilla37
regression
Points:
1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
STR

1) Get a call url from 34 and load it in any Firefox browser
2) Start the call, and accept it.
3) Once established, exit the call.
4) On the link-clicker UI, give feedback
5) Wait for the countdown to complete

Expected Results

-> We revert to the "Start" call view

Actual Results

-> Countdown stops at 1
(Assignee)

Comment 1

3 years ago
Created attachment 8546156 [details] [diff] [review]
Link clicker UI no longer resets to the stat conversation view after giving feedback.

It seems that react is now more strict about updating state whilst in render, possibly it looks at it more recursively or something. In any case, the onAfterFeedbackReceived is changing the state of the store, during the render. There's no need to do it in the render, we can just do it from the setTimeout.
Attachment #8546156 - Flags: review?(nperriault)
Comment on attachment 8546156 [details] [diff] [review]
Link clicker UI no longer resets to the stat conversation view after giving feedback.

Review of attachment 8546156 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8546156 - Flags: review?(nperriault) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/4d9cadf29434
Assignee: nobody → standard8
Iteration: --- → 37.3 - 12 Jan
Points: --- → 1
Priority: -- → P2
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/4d9cadf29434
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Summary: Link clicker UI no longer resets to the stat conversation view after giving feedback → Link clicker UI no longer resets to the start conversation view after giving feedback
You need to log in before you can comment on or make changes to this bug.