Closed
Bug 1119485
Opened 11 years ago
Closed 11 years ago
Link clicker UI no longer resets to the start conversation view after giving feedback
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(Not tracked)
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
STR
1) Get a call url from 34 and load it in any Firefox browser
2) Start the call, and accept it.
3) Once established, exit the call.
4) On the link-clicker UI, give feedback
5) Wait for the countdown to complete
Expected Results
-> We revert to the "Start" call view
Actual Results
-> Countdown stops at 1
|
Assignee | |
Comment 1•11 years ago
|
||
It seems that react is now more strict about updating state whilst in render, possibly it looks at it more recursively or something. In any case, the onAfterFeedbackReceived is changing the state of the store, during the render. There's no need to do it in the render, we can just do it from the setTimeout.
Attachment #8546156 -
Flags: review?(nperriault)
Comment on attachment 8546156 [details] [diff] [review]
Link clicker UI no longer resets to the stat conversation view after giving feedback.
Review of attachment 8546156 [details] [diff] [review]:
-----------------------------------------------------------------
Makes sense.
Attachment #8546156 -
Flags: review?(nperriault) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Assignee: nobody → standard8
Iteration: --- → 37.3 - 12 Jan
Points: --- → 1
Priority: -- → P2
Target Milestone: --- → mozilla37
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Summary: Link clicker UI no longer resets to the stat conversation view after giving feedback → Link clicker UI no longer resets to the start conversation view after giving feedback
You need to log in
before you can comment on or make changes to this bug.
Description
•