1119494 - Add hidden pref to disable "After restart, a tab will open to input.mozilla.org where you can provide us feedback about your e10s experience"-alert and feedback page from opening on startup.

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect)

Description

[Johan C]

It is somewhat annoying to have the "After restart, a tab will open to input.mozilla.org where you can provide us feedback about your e10s experience"-alert pop up every time you disable e10s.

A hidden pref to disable this alert, and prevent the tab from opening after restarting, could lessen the effects of; stress, anxiety, depression, and perhaps the common cold.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

We don't think we're going to invest resources to directly fix this ourselves, but we'll happily accept a patch for it. Do you feel like working on this, Johan? I will gladly mentor you.

Comment 2

[Johan C]

I was actually meaning to upload a patch in a couple of days when I have more time.
I know where to start, I just need to update visual studio and amongst other things.

If someone else wants to work on this, feel free to take it. This is probably a good first bug! :)

Comment 3

[Johan C]

Attachment: Patch v1

Does this require a test?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8548284 [details] [diff] [review]
Patch v1

Review of attachment 8548284 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, Johan.

This looks pretty good - but there are a bunch of unrelated whitespace changes. Can you please remove those? If you want to fix the whitespace issues, let's do that in a separate bug and not intermingle that work with this.

::: browser/app/profile/firefox.js
@@ +1782,5 @@
>  #endif
>  
> +// Temporary pref that disables the e10s feedback request (on disabling e10s).
> +#ifdef NIGHTLY_BUILD
> +pref("browser.disableE10sFeedbackRequest", false);

Let's put this under browser.tabs.remote, so:

browser.tabs.remote.disableFeedbackRequest

::: browser/components/preferences/in-content/main.js
@@ +177,5 @@
>        if (shouldProceed) {
>          for (let prefToChange of prefsToChange) {
>            prefToChange.value = e10sCheckbox.checked;
>          }
> +        if (!Services.prefs.getBoolPref("browser.disableE10sFeedbackRequest") &&

You'll also need to put this pref in to disable browsing to the input page on restart.

Comment 5

[Johan C]

After further discussion with mconley on IRC it's been decided to WONTFIX this.

Bug 1117933 will partly fix what this bug set out to do.