Closed Bug 1119499 Opened 9 years ago Closed 9 years ago

Build warning in unified mode: 'BAD_TLS_INDEX' macro redefined

Categories

(Core :: DOM: Core & HTML, defect)

32 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

I'm not sure if this is more fallout from my adding a new file to xpcom/base, but I saw this warning floating by.  The other definition is in xpcpublic.h.  I was going to take the hacky approach that xpcpublic.h takes and just add a #ifndef BAD_TLS_INDEX guard.  Also, the definitions aren't exactly the same, so I'll take this chance to make them the same...
Well, XPConnect doesn't even use this, so maybe moving it into another file that the places that do use it is the better approach.
This was added to xpcpublic.h in bug 711240, when it was apparently "used all over Gecko" but now I just see it in two files, so I think we can just define it there.
Component: XPCOM → DOM
This just moves the definition into the quota manager.  nsTraceRefcnt can keep using its own slightly different definition.
Attachment #8546187 - Flags: review?(Jan.Varga)
Attachment #8546187 - Attachment is obsolete: true
Attachment #8546187 - Flags: review?(Jan.Varga)
Oops, that's a -1, so the spacing was correct.
Attachment #8546191 - Flags: review?(Jan.Varga)
Attachment #8546191 - Flags: review?(Jan.Varga) → review+
https://hg.mozilla.org/mozilla-central/rev/7e2d8309a20a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.