1119499 - Build warning in unified mode: 'BAD_TLS_INDEX' macro redefined

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

I'm not sure if this is more fallout from my adding a new file to xpcom/base, but I saw this warning floating by.  The other definition is in xpcpublic.h.  I was going to take the hacky approach that xpcpublic.h takes and just add a #ifndef BAD_TLS_INDEX guard.  Also, the definitions aren't exactly the same, so I'll take this chance to make them the same...

Comment 1

[Andrew McCreight [:mccr8]]

Well, XPConnect doesn't even use this, so maybe moving it into another file that the places that do use it is the better approach.

Comment 2

[Andrew McCreight [:mccr8]]

This was added to xpcpublic.h in bug 711240, when it was apparently "used all over Gecko" but now I just see it in two files, so I think we can just define it there.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Define BAD_TLS_INDEX where it is used.

This just moves the definition into the quota manager.  nsTraceRefcnt can keep using its own slightly different definition.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Define BAD_TLS_INDEX where it is used.

Oops, that's a -1, so the spacing was correct.

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e2d8309a20a

Comment 6

[Andrew McCreight [:mccr8]]

try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=92136bccaa63

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e2d8309a20a