Open
Bug 1119505
Opened 9 years ago
Updated 2 years ago
Remove unnecessary AutoSuppressGC
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
NEW
People
(Reporter: sstangl, Unassigned)
Details
Attachments
(1 file)
|
910 bytes,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Trivial patch. As mentioned in the comment, 'lazy' has been made a 'Rooted<LazyScript*>', so GC does not have to be suppressed.
Attachment #8546177 -
Flags: review?(evilpies)
|
||
Comment 1•9 years ago
|
||
This is probably fine, but I would prefer somebody with better GC knowledge to review this.
|
|
||
Updated•9 years ago
|
Attachment #8546177 -
Flags: review?(evilpies) → review?(sphink)
|
||
Updated•9 years ago
|
Attachment #8546177 -
Flags: review?(sphink) → review+
|
Reporter | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c75fef0e790
|
|
Reporter | |
Comment 3•9 years ago
|
||
Backed out, sigh: https://hg.mozilla.org/integration/mozilla-inbound/rev/49d0c7894393 Introduced GC rooting hazards in https://ftp-ssl.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/mozilla-inbound-linux64-b2g-haz/20150114125933/hazards.txt.gz
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•