Closed Bug 111953 Opened 23 years ago Closed 23 years ago

Tables print backgrounds.

Categories

(Core :: Printing: Output, defect)

Product:
Core
Component:
Printing: Output
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.7

People

(Reporter: dcone, Assigned: dcone)

Details

(Keywords: topembed)

Attachments

(3 files)

patch to not do backgrounds for printing
924 bytes, patch
attinasi
: superreview+
Details | Diff | Splinter Review
background on table
7.54 KB, text/html
Details
background on table cell
347 bytes, text/html
Details
Currently tables print backgrounds, this is not good until we have options for the user to set when and how to print backgrounds. So this has to be disabled for printing until bug 96870 is fixed.
Keywords: topembed
Patch to turn off backgrounds for printing. This does not effect general backgrounds since this is not called for the body or html background.. but this will turn off table backgrounds.
r=rods
Comment on attachment 59164 [details] [diff] [review] patch to not do backgrounds for printing sr=attinasi
Attachment #59164 - Flags: superreview+
Wait a sec. So if I have the following: <body style="background-color: white"> <table style="color: white; background-color: black"> </table> </body> What happens with this patch? Does it print white on white? Black on white?
Target Milestone: --- → mozilla0.9.7
That code should print a darker text on white.. just for now until I fix bug 96870. If you did that now.. with dark text on a background.. it would print dark on dark since the text is automatically darkened for body backgrounds. This is all addressed and will be fixed in bug 96870.
Fixed on trunk
Status: NEW → RESOLVED
Closed: 23 years ago
Keywords: edt0.9.4
Resolution: --- → FIXED
Sujay -- This needs to be verified on the trunk before we can plus (+) for 094
what are the test cases we should excersize to verfy this one?
Roland/Boris, I don't have testcases to verify this and my PC is in for service. can one of you verify that this is fixed on latest trunk builds and mark this VERIFIED-FIXED? thanks.
Is 2001-11-26-08-trunk sufficient for verification ?
actually this was fixed on 11/27, so we will need 11/27 and later build to verify on.
verified in 11/27 build.
Status: RESOLVED → VERIFIED
based on the trunk verification, I'm adding + to edt0.9.4
Keywords: edt0.9.4 → edt0.9.4+
Attaching two testcases for further verification if needed. First is testcase with table background; second is testcase with cell background. Verified fixed on 11_29_09_trunk build.
Attached file background on table —
EDT - Let's get this on the branch tonite if we can - Embedding friends are pulling tomorrow.
checked into the branch
Keywords: fixed0.9.4
verified in 1/13 branch build.
Keywords: verified0.9.4
Keywords: fixed0.9.4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: