1119583 - "mach xpcshell-test" busted on Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

$ ./mach xpcshell-test
From _tests: Kept 30421 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.29 LOG: MainThread mozdevice INFO will use zip to push directories
using APK: /home/gbrown/objdirs/droid/dist/fennec-37.0a1.en-US.android-arm.apk
Warning: only the first test path argument will be used.
Pushing xpcshell..
...
pushing /home/gbrown/objdirs/droid/_tests/xpcshell
unable to determine app root: 'DeviceManagerADB' object has no attribute 'getAppRoot'
...
 0:50.44 LOG: MainThread INFO Running tests sequentially.
 0:50.44 SUITE_START: MainThread 1869
 0:50.79 TEST_START: Thread-146 chrome/test/unit/test_abi.js
...
 0:51.26 PROCESS_OUTPUT: Thread-146 (pid:chrome/test/unit/test_abi.js) "Couldn't find application file."
 0:51.27 TEST_END: Thread-146 FAIL, expected PASS
xpcshell return code: 1


Because of "unable to determine app root", GRE_HOME is not set, causing "Couldn't find application file." and immediate xpcshell failure.

Root cause is that the mach command uses devicemanagerADB/SUT instead of DroidADB/SUT.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: use Droid instead of devicemanager

This just swaps DroidADB/SUT for devicemanagerADB/SUT in the Android xpcshell mach command. 

Works like a charm:

$ ./mach xpcshell-test
From _tests: Kept 30421 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.29 LOG: MainThread mozdevice INFO will use zip to push directories
using APK: /home/gbrown/objdirs/droid/dist/fennec-37.0a1.en-US.android-arm.apk
Warning: only the first test path argument will be used.
Pushing xpcshell..
...
pushing /home/gbrown/objdirs/droid/_tests/xpcshell
 0:46.93 LOG: MainThread mozdevice INFO chmod /data/local/xpcb/BadCertServer
...
 0:50.90 LOG: MainThread mozdevice INFO chmod /data/local/xpcb
 0:51.01 LOG: MainThread INFO Running tests sequentially.
 0:51.01 SUITE_START: MainThread 1869
 0:51.35 TEST_START: Thread-146 chrome/test/unit/test_abi.js
...
 0:52.16 PROCESS_OUTPUT: Thread-146 (pid:chrome/test/unit/test_abi.js) "JavaScript warning: /sdcard/tests/xpcshell/head.js, line 54: JavaScript 1.7's let blocks are deprecated"
 0:52.16 PROCESS_OUTPUT: Thread-146 (pid:chrome/test/unit/test_abi.js) "JavaScript warning: /sdcard/tests/xpcshell/head.js, line 74: JavaScript 1.7's let blocks are deprecated"
 0:52.16 PROCESS_OUTPUT: Thread-146 (pid:chrome/test/unit/test_abi.js) "JavaScript warning: /sdcard/tests/xpcshell/head.js, line 106: JavaScript 1.7's let blocks are deprecated"
 0:49.54 LOG: Thread-146 INFO (xpcshell/head.js) | test MAIN run_test pending (1)
 0:49.54 TEST_STATUS: Thread-146 run_test PASS [run_test : 56] true == true
 0:49.55 TEST_STATUS: Thread-146 run_test PASS [run_test : 57] true == true
 0:49.55 TEST_STATUS: Thread-146 run_test PASS [run_test : 58] true == true
 0:49.55 TEST_STATUS: Thread-146 run_test PASS [run_test : 59] true == true
 0:49.55 LOG: Thread-146 INFO (xpcshell/head.js) | test MAIN run_test finished (1)
 0:49.56 LOG: Thread-146 INFO exiting test
 0:52.17 TEST_END: Thread-146 Harness PASS. Subtests passed 4/4. Unexpected 0

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8546277 [details] [diff] [review]
use Droid instead of devicemanager

Review of attachment 8546277 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a0cf4b46f9e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a0cf4b46f9e