1119627 - Add Arabic font preference to Android's prefs

Status: RESOLVED DUPLICATE of bug 1341986

(Core :: Graphics: Text, defect)

Description

[Makoto Kato [:m_kato]]

Arabic font on Android is the following.  But we don't have no entry into prefs.js such as font.name.serif.ar.

Nexus 9 (Android 5.0)
- Serif .. Noto Naskh Arabic

Nexus 5 (Android 4.4) / Galaxy Nexus (Android 4.0 /4.2)
- Serif ... Droid Arabic Naskh

HTC Desire HD (Android 2.3)
- Sans ... Droid Sans Arabic

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

It looks like we can already display Arabic fine using the fonts we've selected. What would adding the pref give us?

Comment 2

[Makoto Kato [:m_kato]]

see telemetry data
http://telemetry.mozilla.org/#filter=nightly%2F38%2FSYSTEM_FONT_FALLBACK_SCRIPT%2Fsaved_session%2FFennec%2FAndroid&aggregates=multiselect-all!Submissions&evoOver=Builds&locked=true&sanitize=true&renderhistogram=Graph

We always use fallback code for arabic font since no *.ar entry into prefs.js

This is performance and optimization issue.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Ok, I understand a little better now. The numbers in the histogram are the script numbers? Are all of those for Arabic, or are we missing other stuff?

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Add Arabic fonts to prefs.js

Add Arabic fonts such as Noto font to Android's prefs

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8569116 [details] [diff] [review]
Add Arabic fonts to  prefs.js

Review of attachment 8569116 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this looks like it should be fine. Sorry for the delay here.

Comment 6

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/626149a7ddcb

Comment 7

[Makoto Kato [:m_kato]]

ah, since ar font is set, bug 548751's reftest is failure.

I backout this then I will investigate more fix.
https://hg.mozilla.org/integration/mozilla-inbound/rev/639aea01d396

Comment 8

[Makoto Kato [:m_kato]]

Reftest for lang attribute has no arabic character test even if using lang=ar.  As result, it used on some fonts or Droid Sans Fallback since preference has no arabic font settings.

We should add arabic character or symbols to these reftests.