ship-it field for "additional info to release-drivers" should handle unicode better

RESOLVED INCOMPLETE

Status

Release Engineering
Ship It
RESOLVED INCOMPLETE
3 years ago
10 months ago

People

(Reporter: lsblakk, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

today's builds broke on release-runner because of a unicode error:

2015-01-08 19:28:36,942 - DEBUG - Releasing lock: /builds/releaserunner/tools/buildfarm/release/.release-runner.lock
Traceback (most recent call last):
 File "release-runner.py", line 469, in <module>
   main(options)
 File "release-runner.py", line 339, in main
   sendMailRD(smtp_server, notify_from, cfgFile, release)
 File "release-runner.py", line 238, in sendMailRD
   smtp_server=smtpServer)
 File "/builds/releaserunner/tools/lib/python/util/sendmail.py", line 11, in sendmail
   m = MIMEText(body)
 File "/tools/python27/lib/python2.7/email/mime/text.py", line 30, in __init__
   self.set_payload(_text, _charset)
 File "/tools/python27/lib/python2.7/email/message.py", line 226, in set_payload
   self.set_charset(charset)
 File "/tools/python27/lib/python2.7/email/message.py", line 262, in set_charset
   self._payload = self._payload.encode(charset.output_charset)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 42: ordinal not in range(128)



Because the message to release drivers contained an ':


INFO - Got a new release request: {'status': 'Pending', 'comment': u'As mentioned in previously:\r\n\r\nWe\u2019re doing a build 3 of 35.0 Desktop for:\r\n\r\n* 1119189, 1117140, 1110760 \r\n\r\nThe plan if there are no surprises is to ship this build to beta users by end of day tomorrow so it gets some time to collect feedback before Tuesday\u2019s release date.\r\n\r\nThe mobile beta 11 and RC have patches from bug 1110229 landed to fix bug 1073554 and the plan is to also ship the beta before end of day tomorrow so we can get feedback over the weekend.\r\n', 'product': 'firefox', 'submittedAt': '2015-01-09T03:10:06+00:00', 'submitter': 'lsblakk@mozilla.com',
Created attachment 8546385 [details] [diff] [review]
band-aid.diff

I applied the following band aid on bm81 to make release-runner happy. We may need to revise other places where we use sendmail() as well.
Component: Tools → Release Automation
QA Contact: hwine → bhearsum
rail, I think that is fine, we are not using sending sendmail() elsewhere (at least with the relman comment).
Mass component change for ship it bugs.
Component: Release Automation → Ship It
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.