Closed Bug 1119639 Opened 7 years ago Closed 7 years ago

[Stingray][Home]Consider device pixel ratio when fetching app icon

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: suchiu)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
dwi2
: review+
Details | Review
We should consider device pixel ratio when fetching app icon in Home app, instead of a plain hardcoded value.
Whiteboard: [ft:conndevices][ETA:1/12] → [ft:conndevices]
Attached file Pull Request
1. Make FULLSIZED_ICON scale with devicePixelRatio
2. Remove cached icon url for app-deck, and apply icons in manifest.webapp instead.
3. Tested by changing value of FULLSIZED_ICO manually.
Attachment #8548715 - Flags: review?(tzhuang)
Assign to Sung since he is working on it.
Assignee: nobody → suchiu
Status: NEW → ASSIGNED
Comment on attachment 8548715 [details] [review]
Pull Request

looks good to me, thanks
Attachment #8548715 - Flags: review?(tzhuang) → review+
Component: Gaia → Gaia::TV::Home
Gaia-try is green
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d836d5bac9f9

Landed on master
https://github.com/mozilla-b2g/gaia/commit/5ec456d1a79e86997100ea5a8d7ab12d99e4e468
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Back out because commit message is not in correct format
https://github.com/mozilla-b2g/gaia/commit/6b22c65e5bbeb8f44f555178b8c9333f00af4785
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Landed on master
https://github.com/mozilla-b2g/gaia/commit/b6eab76ad29bab6faf0ebfacc37c9b960311f409
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.