Closed
Bug 1119639
Opened 9 years ago
Closed 9 years ago
[Stingray][Home]Consider device pixel ratio when fetching app icon
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: suchiu)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
We should consider device pixel ratio when fetching app icon in Home app, instead of a plain hardcoded value.
Reporter | ||
Updated•9 years ago
|
Whiteboard: [ft:conndevices][ETA:1/12] → [ft:conndevices]
Reporter | ||
Updated•9 years ago
|
Blocks: CardUI-Followup
Assignee | ||
Comment 1•9 years ago
|
||
1. Make FULLSIZED_ICON scale with devicePixelRatio 2. Remove cached icon url for app-deck, and apply icons in manifest.webapp instead. 3. Tested by changing value of FULLSIZED_ICO manually.
Attachment #8548715 -
Flags: review?(tzhuang)
Reporter | ||
Comment 2•9 years ago
|
||
Assign to Sung since he is working on it.
Assignee: nobody → suchiu
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8548715 [details] [review] Pull Request looks good to me, thanks
Attachment #8548715 -
Flags: review?(tzhuang) → review+
Reporter | ||
Updated•9 years ago
|
Component: Gaia → Gaia::TV::Home
Reporter | ||
Comment 4•9 years ago
|
||
Gaia-try is green https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d836d5bac9f9 Landed on master https://github.com/mozilla-b2g/gaia/commit/5ec456d1a79e86997100ea5a8d7ab12d99e4e468
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•9 years ago
|
||
Back out because commit message is not in correct format https://github.com/mozilla-b2g/gaia/commit/6b22c65e5bbeb8f44f555178b8c9333f00af4785
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•9 years ago
|
||
Revised Pull Request: https://github.com/mozilla-b2g/gaia/pull/27554
Reporter | ||
Comment 7•9 years ago
|
||
Landed on master https://github.com/mozilla-b2g/gaia/commit/b6eab76ad29bab6faf0ebfacc37c9b960311f409
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•