1119639 - [Stingray][Home]Consider device pixel ratio when fetching app icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

We should consider device pixel ratio when fetching app icon in Home app, instead of a plain hardcoded value.

Comment 1

[Sung Chiu[:sungchiu]]

Attachment: Pull Request

1. Make FULLSIZED_ICON scale with devicePixelRatio
2. Remove cached icon url for app-deck, and apply icons in manifest.webapp instead.
3. Tested by changing value of FULLSIZED_ICO manually.

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Assign to Sung since he is working on it.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8548715 [details] [review]
Pull Request

looks good to me, thanks

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Gaia-try is green
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d836d5bac9f9

Landed on master
https://github.com/mozilla-b2g/gaia/commit/5ec456d1a79e86997100ea5a8d7ab12d99e4e468

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Back out because commit message is not in correct format
https://github.com/mozilla-b2g/gaia/commit/6b22c65e5bbeb8f44f555178b8c9333f00af4785

Comment 6

[Sung Chiu[:sungchiu]]

Revised Pull Request:
https://github.com/mozilla-b2g/gaia/pull/27554

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Landed on master
https://github.com/mozilla-b2g/gaia/commit/b6eab76ad29bab6faf0ebfacc37c9b960311f409