1119670 - Implement processing of scope member of web manifest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

Implement support in the manifest processor for processing the scope member of a manifest.

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: 0001-1119670-Implement-processing-of-scope-member-of-web-.patch

Initial implementation of scope processor. 

Any idea how I push to try from git? Or how to use `git-push-to-try`? I don't know what parameters it's asking for :( Filed a bug on the tools people for help, but maybe you know?

Comment 2

[Marcos Caceres [:marcosc]]

Ok, got the try thing working:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec1da0d45c1f

Comment 3

[(no longer active)]

Comment on attachment 8546430 [details] [diff] [review]
0001-1119670-Implement-processing-of-scope-member-of-web-.patch

Review of attachment 8546430 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Apologies for the delay.

::: dom/manifest/ManifestProcessor.jsm
@@ +143,5 @@
> +        expectedType: 'string',
> +        dontTrim: true
> +      },
> +      value = extractValue(spec);
> +    

Nit: please remove the trailing whitespace.  There's one at the end of this file too.

@@ +153,5 @@
> +      issueDeveloperWarning(msg);
> +      return undefined;
> +    }
> +
> +    if(scopeURL.origin !== docURL.origin){

Nit: space around the parenthesis, like:

if (foo) {

Also:

try {

} catch(e) {
}

Comment 4

[Marcos Caceres [:marcosc]]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #3)
> Comment on attachment 8546430 [details] [diff] [review]
> 0001-1119670-Implement-processing-of-scope-member-of-web-.patch
> 
> Review of attachment 8546430 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice! Apologies for the delay.

np Appreciate the review! 
 
> ::: dom/manifest/ManifestProcessor.jsm
> @@ +143,5 @@
> > +        expectedType: 'string',
> > +        dontTrim: true
> > +      },
> > +      value = extractValue(spec);
> > +    
> 
> Nit: please remove the trailing whitespace.  

Fixed throughout, including around ( ) and try catch. 

>There's one at the end of this file too.

I left the white space at the end as there is space separating each of the functions declared in this code already.

submitting a new patch with the fixes...

Comment 5

[Marcos Caceres [:marcosc]]

Attachment: 0001-1119670-Implement-processing-of-scope-member-of-web-.patch

Comment 6

[Marcos Caceres [:marcosc]]

Just in case this is needed, I sent it again to try with the white space changes: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d87b634b0043

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0066a6e5865

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b0066a6e5865