1119673 - KeyboardEvent.key of Home key will be changed to 'MozHomeScreen'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

According to bug 1116762, .key value is going to be 'MozHomeScreen' for Home key. We should make modification in browser_key_event_manager.js accordingly to prevent home key malfunction.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

This bug must be fixed before 1116762.

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: PR

Hi Tim,

According to bug 1116762, KeyboardEvent.key value of Home key is going to be MozHomeScreen. We add .key value mapping in browser_key_event_manager.js in this patch accordingly, in order to prevent Home key malfunction.

Please help to review the patch, thanks.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8546435 [details] [review]
PR

Just to make sure, we will be removing some of these .key values in the futures right?

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Yes, we will remove 'home' and 'exit' in the future. Because 'home' and 'exit' stand for different meaning from that of 'Home' key on phones in DOM Level 3 standard.

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Forgot to say that, the removing works will be in bug 1117654. We should construct a constant '.key' value mapping table for Gaia in bug 1117654. 
And in Gaia, we compare KeyboardEvent.key value with that table instead of comparing literal string directly. Because string values of '.key' might change from time to time before the standard is froze.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Gaia-Try result
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=6915d74e906f

Landed on mater
https://github.com/mozilla-b2g/gaia/commit/fa4af5f6d5ed1c3c0223447b316bcc60f300cb8f