Add tests for GlobalOverlayWindowManager

RESOLVED FIXED

Status

Firefox OS
Gaia::System::Window Mgmt
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Bug 1101029 added tests for GlobalOverlayWindow but not for GlobalOverlayWindowManager.
(Assignee)

Updated

3 years ago
Assignee: nobody → ferjmoreno
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1163461
Created attachment 8607536 [details] [review]
[gaia] ferjm:bug1119705.gowm.tests > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8607536 - Flags: review?(alive)
Comment on attachment 8607536 [details] [review]
[gaia] ferjm:bug1119705.gowm.tests > mozilla-b2g:master

Cool, thanks for doing this!
Attachment #8607536 - Flags: review?(alive) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
For some reason autolander landed this, though it started failing on TC gaia-master. Perhaps it was intermittent?

Backout: https://github.com/mozilla-b2g/gaia/commit/81136a63b7cb5a303eacccc5b1e03dbf6fb1001d

Example of failure: https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/rEIdNGO-TECdPbsxh5TEiQ/1/public/logs/live_backing.log

Fernando - could you take a look?
Status: RESOLVED → REOPENED
Flags: needinfo?(ferjmoreno)
Resolution: FIXED → ---
(Assignee)

Comment 6

3 years ago
I have no idea why this didn't fail initially. It isn't an intermittent. The error was caused while merging with bug 1162383 [1]. I wasn't considering that change on the tests.

[1] https://github.com/mozilla-b2g/gaia/pull/30142/files?diff=unified#diff-3d96e1deaba060cc6854c94738e23d70
Flags: needinfo?(ferjmoreno)
Created attachment 8608171 [details] [review]
[gaia] ferjm:bug1119705.gowm.tests > mozilla-b2g:master
(Assignee)

Comment 8

3 years ago
Comment on attachment 8608171 [details] [review]
[gaia] ferjm:bug1119705.gowm.tests > mozilla-b2g:master

Kevin, do you mind taking a look at the patch, please? The change wrt the previous patch is on the "system-resize" suite.

Thanks!
Attachment #8608171 - Flags: review?(kgrandon)
Comment on attachment 8608171 [details] [review]
[gaia] ferjm:bug1119705.gowm.tests > mozilla-b2g:master

Looks good to me. Thanks!
Attachment #8608171 - Flags: review?(kgrandon) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #6)
> I have no idea why this didn't fail initially. It isn't an intermittent. The
> error was caused while merging with bug 1162383 [1]. I wasn't considering
> that change on the tests.
> 
> [1]
> https://github.com/mozilla-b2g/gaia/pull/30142/files?diff=unified#diff-
> 3d96e1deaba060cc6854c94738e23d70

This is sad. I wonder if Audolander can be smarter about this, maybe merge (and test) the patches in sequences.
(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #11)
> This is sad. I wonder if Audolander can be smarter about this, maybe merge
> (and test) the patches in sequences.

Yeah, it's actually *supposed* to prevent this, not sure what happened but I will look into it.
You need to log in before you can comment on or make changes to this bug.