Closed
Bug 1119713
Opened 9 years ago
Closed 9 years ago
[Stingray] KeyNavigationAdapter should handle both keydown and keyup event
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: johnhu)
References
Details
(Whiteboard: [ft:conndevices][ETA:1/23])
Attachments
(1 file)
KeyNavigationAdapter should handle both keydown and keyup event, and fire events accordingly. Because not every smart-screen application needs keyup event, some may need keydown event.
Assignee | ||
Comment 1•9 years ago
|
||
This introduce a regression that app deck and system app receives keyboard event at the same time.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → im
Assignee | ||
Comment 2•9 years ago
|
||
I will create another issue to fix the issue at comment 1
Assignee: im → nobody
Assignee | ||
Comment 4•9 years ago
|
||
In the navigation cases, we should use keydown to have multiple keydown events fired while hold the key. But with the click case, we should use keyup to handle it. Our plan is to extend the KeyNavigationAdapter to have extra events/arguments to tell this is keydown or keyup and use them at the correct place. If this is high priority, I can fix it.
Flags: needinfo?(im)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → im
Comment 5•9 years ago
|
||
Please also label an ETA. Thank you!
Assignee | ||
Comment 6•9 years ago
|
||
Rex, Please review this patch since you are the creator of this file.
Attachment #8551038 -
Flags: review?(rexboy)
Assignee | ||
Updated•9 years ago
|
Blocks: 1123172
Whiteboard: [ft:conndevices] → [ft:conndevices][ETA:1/23]
Comment 7•9 years ago
|
||
Comment on attachment 8551038 [details] [review] handle keydown/up Looks good to me. I think we can add some comment to note the reason for using keyup.
Attachment #8551038 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 8•9 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/174cc78d38ea52a3ef0a51697e42e7005bcdfef3 gaia try has two known issues. https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=e80287e15efc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•