KeyNavigationAdapter should handle both keydown and keyup event, and fire events accordingly. Because not every smart-screen application needs keyup event, some may need keydown event.
This introduce a regression that app deck and system app receives keyboard event at the same time.
I will create another issue to fix the issue at comment 1
John, our partner is asking this bug, what's your plan?
In the navigation cases, we should use keydown to have multiple keydown events fired while hold the key. But with the click case, we should use keyup to handle it. Our plan is to extend the KeyNavigationAdapter to have extra events/arguments to tell this is keydown or keyup and use them at the correct place. If this is high priority, I can fix it.
Please also label an ETA. Thank you!
Created attachment 8551038 [details] [review] handle keydown/up Rex, Please review this patch since you are the creator of this file.
Comment on attachment 8551038 [details] [review] handle keydown/up Looks good to me. I think we can add some comment to note the reason for using keyup.
merged to master: https://github.com/mozilla-b2g/gaia/commit/174cc78d38ea52a3ef0a51697e42e7005bcdfef3 gaia try has two known issues. https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=e80287e15efc