Closed
Bug 1119748
Opened 9 years ago
Closed 9 years ago
[Stingray] use keydown to change the focus
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
We had changed to use keyup event to switch the focus in Home app and App deck. This breaks holding key to move focus continuously. According to UX's feedback, we should have it and use keydown.
|
Assignee | |
Comment 1•9 years ago
|
||
dwi2, Please review this patch. I had changed to use click instead of depending on keydown.
Attachment #8547412 -
Flags: review?(tzhuang)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8547412 [details] [review] use click and revert the keyup to keydown. Looks good to me, thanks
Attachment #8547412 -
Flags: review?(tzhuang) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/eb9cdf15c74f2a8d4756e43e9508cb13474938f5 https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=bc9431a51f00
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•