IonMonkey MIPS: Fix latest build issues (unboxObject)

RESOLVED FIXED in mozilla38

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rankov, Assigned: rankov)

Tracking

Trunk
mozilla38
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8546613 [details] [diff] [review]
1119783-Fix-build.patch
Attachment #8546613 - Flags: review?(jdemooij)
Comment on attachment 8546613 [details] [diff] [review]
1119783-Fix-build.patch

Review of attachment 8546613 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips/MacroAssembler-mips.cpp
@@ +2564,5 @@
>  void
> +MacroAssemblerMIPSCompat::unboxNonDouble(const BaseIndex &src, Register dest)
> +{
> +    computeScaledAddress(src, SecondScratchReg);
> +    ma_lw(dest, Address(SecondScratchReg, PAYLOAD_OFFSET));

We should either use src.offset + PAYLOAD_OFFSET or assert src.offset == 0, right?
Attachment #8546613 - Flags: review?(jdemooij) → review+
(Assignee)

Comment 3

3 years ago
(In reply to Jan de Mooij [:jandem] from comment #2)
> Comment on attachment 8546613 [details] [diff] [review]
> 1119783-Fix-build.patch
> 
> Review of attachment 8546613 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips/MacroAssembler-mips.cpp
> @@ +2564,5 @@
> >  void
> > +MacroAssemblerMIPSCompat::unboxNonDouble(const BaseIndex &src, Register dest)
> > +{
> > +    computeScaledAddress(src, SecondScratchReg);
> > +    ma_lw(dest, Address(SecondScratchReg, PAYLOAD_OFFSET));
> 
> We should either use src.offset + PAYLOAD_OFFSET or assert src.offset == 0,
> right?

You are right. I will fix this.
QA Contact: branislav.rankov
(Assignee)

Comment 4

3 years ago
Created attachment 8547651 [details] [diff] [review]
1119783-Fix-build.patch

Carry review from previous patch.
Assignee: nobody → branislav.rankov
Attachment #8546613 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8547651 - Flags: review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f2b89a7f71a
https://hg.mozilla.org/mozilla-central/rev/2f2b89a7f71a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.