Closed
Bug 1119813
Opened 10 years ago
Closed 10 years ago
merge remote-troubleshooting version into main generic feedback code
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=user c=feedback p=1 s=input.2015q1)
The remote-troubleshooting stuff is good to go. We need to "land the experiment".
That involves:
1. merging all the generic feedback dev stuff into their appropriate generic feedback counterparts (css, js, html template, view)
2. change the feedbackdev flag from Yes back to No (this should be done on a server-by-server basis)
Assignee | ||
Comment 1•10 years ago
|
||
Grabbing this to work on next week.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Tweaking the title, though it's still pretty weird. Making this block bug #1104932 since that's the tracker.
Blocks: 1104932
Summary: remove feedbackdev flag for remote-troubleshooting → merge remote-troubleshooting version into main generic feedback code
Assignee | ||
Comment 3•10 years ago
|
||
When doing this, we should clean up the javascript related to putting the browser data in the right place. There's a mild race condition as it stands. Instead of doing what we're doing, we should do all the work when the user clicks on Submit and if it's checked grab the browser data otherwise leave it.
Assignee | ||
Comment 4•10 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/474
I skipped the stuff in comment #3 and instead created bug #1128693 for it and marked it as mentored.
Still outstanding is changing the flag from yes back to no. I'll do that by hand after I deploy this.
Whiteboard: u=user c=feedback p= s=input.2015q1 → u=user c=feedback p=1 s=input.2015q1
Assignee | ||
Comment 5•10 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/16f0a7838ce2cbee18b73b3d06f18c4d1d6f3d04
Will deploy and then change flags from yes to no tomorrow.
Assignee | ||
Comment 6•10 years ago
|
||
Pushed this just now. Changed the "feedbackdev" flag to "Everyone=No" in -stage and -prod environments. Marking as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•