Closed
Bug 1119818
Opened 9 years ago
Closed 9 years ago
various UUID has to be updated for the 36 beta release
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: Sylvestre, Assigned: Sylvestre)
Details
Attachments
(5 files, 1 obsolete file)
1.08 KB,
patch
|
jib
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.28 KB,
patch
|
jdm
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
913 bytes,
patch
|
jib
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.13 KB,
patch
|
Gavin
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
765 bytes,
patch
|
bzbarsky
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Patches arrive soon
Assignee | ||
Comment 1•9 years ago
|
||
UUID was not updated in commit: https://hg.mozilla.org/mozilla-central/diff/6f383f465a4d/dom/media/nsIDOMNavigatorUserMedia.idl
Attachment #8546690 -
Flags: review?(jib)
Attachment #8546690 -
Flags: review?(bzbarsky)
Comment 2•9 years ago
|
||
Comment on attachment 8546690 [details] [diff] [review] 234677.diff r=me
Attachment #8546690 -
Flags: review?(jib) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Not updated in commit: https://hg.mozilla.org/mozilla-central/diff/49e5c7d46ea0/dom/media/nsIDOMNavigatorUserMedia.idl
Attachment #8546695 -
Flags: review?(linuxwolf)
Attachment #8546695 -
Flags: review?(jib)
Assignee | ||
Comment 4•9 years ago
|
||
Missing dump in this commit: https://hg.mozilla.org/mozilla-central/diff/cc451b07de72/dom/network/interfaces/nsITCPSocketParent.idl
Attachment #8546699 -
Flags: review?(josh)
Attachment #8546699 -
Flags: review?(bugmail)
Comment 5•9 years ago
|
||
Comment on attachment 8546690 [details] [diff] [review] 234677.diff Review of attachment 8546690 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching that, but you should touch nsIDOMGetUserMediaErrorCallback, not nsIDOMGetUserMediaSuccessCallback.
Attachment #8546690 -
Flags: review-
Comment 6•9 years ago
|
||
Comment on attachment 8546695 [details] [diff] [review] 234678.diff Review of attachment 8546695 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8546695 -
Flags: review?(jib) → review+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → sledru
Assignee | ||
Comment 7•9 years ago
|
||
Right, second try!
Attachment #8546690 -
Attachment is obsolete: true
Attachment #8546690 -
Flags: review?(bzbarsky)
Attachment #8546708 -
Flags: review?(jib)
Assignee | ||
Comment 8•9 years ago
|
||
missing uuid change in this commit: https://hg.mozilla.org/mozilla-central/diff/4a7db36c3c75/embedding/components/webbrowserpersist/nsIWebBrowserPersist.idl
Attachment #8546711 -
Flags: review?(sstamm)
Attachment #8546711 -
Flags: review?(jst)
Updated•9 years ago
|
Attachment #8546699 -
Flags: review?(josh)
Attachment #8546699 -
Flags: review?(bugmail)
Attachment #8546699 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
I believe that a uuid change is necessary but I would like confirmation. In https://hg.mozilla.org/mozilla-central/diff/8d3304b7e0e0/layout/xul/tree/nsITreeBoxObject.idl, we changed the type of a variable and we hide this interface (so, i guess the uuid change was not necessary in this case). However, in https://hg.mozilla.org/mozilla-central/rev/04142473004f, we turned it to public again but didn't update the uuid. So, with the change of type, I guess we need a change of uuid, am I correct?
Attachment #8546717 -
Flags: review?(bzbarsky)
Comment 10•9 years ago
|
||
Comment on attachment 8546717 [details] [diff] [review] nsITreeBoxObject.diff > so, i guess the uuid change was not necessary in this case No, it was still necessary. uuid is mostly about binary stuff, which can use non-scriptable interfaces. r=me.
Attachment #8546717 -
Flags: review?(bzbarsky) → review+
Updated•9 years ago
|
Attachment #8546708 -
Flags: review?(jib) → review+
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8546717 [details] [diff] [review] nsITreeBoxObject.diff [Triage Comment] a=me
Attachment #8546717 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8546708 [details] [diff] [review] 234677.diff [Triage Comment] a=me
Attachment #8546708 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8546699 [details] [diff] [review] foo.diff [Triage Comment] a=me
Attachment #8546699 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8546695 [details] [diff] [review] 234678.diff [Triage Comment] a=me
Attachment #8546695 -
Flags: review?(linuxwolf) → approval-mozilla-aurora+
Assignee | ||
Comment 15•9 years ago
|
||
Patches should also land in m-c. Ryan, if you feel like approving nsIWebBrowserPersist.diff, don't hesitate :)
Keywords: checkin-needed
Updated•9 years ago
|
Attachment #8546711 -
Flags: review?(sstamm)
Attachment #8546711 -
Flags: review?(jst)
Attachment #8546711 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8546711 -
Flags: approval-mozilla-aurora+
Assignee | ||
Updated•9 years ago
|
status-firefox36:
--- → affected
Comment 16•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cac64af410a1 https://hg.mozilla.org/releases/mozilla-aurora/rev/75177371cb85
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox37:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•